This repository has been archived by the owner on Dec 1, 2018. It is now read-only.
Switch Stackdriver sink to grpc-based Stackdriver API #1906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
do-not-merge/work-in-progress
|
This change is |
k8s-ci-robot
added
size/XXL
kawych
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
kawych
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
piosz
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
@pongad |
|
/retest |
| return &sd_api.TimeSeries{ | ||
| Metric: &sd_api.Metric{ | ||
| func createTimeSeries(resource string, resourceLabels map[string]string, metadata *metricMetadata, point *monitoringpb.Point) *monitoringpb.TimeSeries { | ||
| //monitoringpb. |
|
/retest |
pongad
reviewed
Dec 11, 2017
| "google.golang.org/api/googleapi" | ||
| sd_api "google.golang.org/api/monitoring/v3" | ||
| google_api5 "google.golang.org/genproto/googleapis/api/metric" | ||
| google_api4 "google.golang.org/genproto/googleapis/api/monitoredres" |
| timestamp time.Time, labels map[string]string, collectionStartTime time.Time, entityCreateTime time.Time) []*sd_api.TimeSeries { | ||
| timeseries := make([]*sd_api.TimeSeries, 0) | ||
| timestamp time.Time, labels map[string]string, collectionStartTime time.Time, entityCreateTime time.Time) []*monitoringpb.TimeSeries { | ||
| timeseries := make([]*monitoringpb.TimeSeries, 0) |
There was a problem hiding this comment.
var timeseries []*monitoringpb.TimeSeries? That way empty arrays don't allocate.
| @@ -268,7 +270,7 @@ func (sink *StackdriverSink) requestSender(reqQueue chan *sd_api.CreateTimeSerie | |||
| } | |||
There was a problem hiding this comment.
Isn't this loop just
for req := range reqQueue {sink.sendOneRequest(req)}?
| startTime := time.Now() | ||
| empty, err := sink.stackdriverClient.Projects.TimeSeries.Create(fullProjectName(sink.project), req).Do() | ||
| err := sink.stackdriverClient.CreateTimeSeries(context.Background(), req, gax.WithGRPCOptions()) |
There was a problem hiding this comment.
No need to write gax.WithGRPCOptions() if you don't pass options.
This function is used for passing more options to gRPC layer.
| return &sd_api.CreateTimeSeriesRequest{TimeSeries: make([]*sd_api.TimeSeries, 0)} | ||
| func getReq(project string) *monitoringpb.CreateTimeSeriesRequest { | ||
| return &monitoringpb.CreateTimeSeriesRequest{ | ||
| TimeSeries: make([]*monitoringpb.TimeSeries, 0), |
| return &monitoringpb.Point{ | ||
| Interval: &monitoringpb.TimeInterval{ | ||
| EndTime: &google_protobuf2.Timestamp{Seconds: endTime.Unix(), Nanos: int32(endTime.Nanosecond())}, | ||
| StartTime: &google_protobuf2.Timestamp{Seconds: startTime.Unix(), Nanos: int32(startTime.Nanosecond())}, |
There was a problem hiding this comment.
I think it actually returns different type.
kawych
added a commit
that referenced
this pull request
Dec 11, 2017
Cherry-pick changes from PR #1906 to 1.5 release branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR together with #1907 lowers Heapster maximum resource usage by 60% CPU and 25% memory (tested over 2 hours on GCE, 100-node cluster with 3k running user pods).