Skip to content

Fix CVE-2025-61729: Upgrade Go toolchain from 1.24.6 to 1.25.5#545

Closed
Harishma-Hari wants to merge 2 commits intokubernetes-csi:masterfrom
Harishma-Hari:fix_vulnerability_go
Closed

Fix CVE-2025-61729: Upgrade Go toolchain from 1.24.6 to 1.25.5#545
Harishma-Hari wants to merge 2 commits intokubernetes-csi:masterfrom
Harishma-Hari:fix_vulnerability_go

Conversation

@Harishma-Hari
Copy link

@Harishma-Hari Harishma-Hari commented Jan 19, 2026

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR fixes CVE-2025-61729, a high-severity security vulnerability in Go's crypto/x509 package. The vulnerability causes excessive resource consumption in HostnameError.Error() due to unbounded host printing and quadratic string concatenation, which can be exploited by malicious actors providing specially crafted certificates.

The fix upgrades the Go toolchain from version 1.24.6 (vulnerable) to version 1.25.5 (patched).

Which issue(s) this PR fixes:

Fixes CVE-2025-61729

Special notes for your reviewer:

  • This is a security patch that only updates the Go toolchain version
  • No code changes required - the fix is in the Go standard library
  • Build and tests pass successfully with Go 1.25.5
  • CVSS Score: 7.5 (High severity)
  • Attack Vector: Network (AV:N)
  • No user interaction required (UI:N)

Does this PR introduce a user-facing change?:

Fixed CVE-2025-61729 by upgrading Go toolchain to 1.25.5, addressing a high-severity vulnerability in crypto/x509 that could cause excessive resource consumption.

- Updated toolchain version in go.mod to address crypto/x509 vulnerability
- CVE-2025-61729: Excessive resource consumption in HostnameError.Error()
- Severity: High (CVSS 7.5)
- Fix available in Go 1.25.5
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 19, 2026
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Harishma-Hari
Once this PR has been reviewed and has the lgtm label, please assign msau42 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from gnufied and pohly January 19, 2026 10:38
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 19, 2026
@k8s-ci-robot
Copy link
Contributor

Welcome @Harishma-Hari!

It looks like this is your first PR to kubernetes-csi/node-driver-registrar 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/node-driver-registrar has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 19, 2026
@k8s-ci-robot
Copy link
Contributor

Hi @Harishma-Hari. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 19, 2026
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 19, 2026
@jsafrane
Copy link
Contributor

/close
this was merged as part of #548

@k8s-ci-robot
Copy link
Contributor

@jsafrane: Closed this PR.

Details

In response to this:

/close
this was merged as part of #548

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants