-
Notifications
You must be signed in to change notification settings - Fork 116
2.5.0 changelog #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
2.5.0 changelog #133
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| # Release notes for v2.5.0 | ||
|
|
||
| [Documentation](https://kubernetes-csi.github.io/docs/) | ||
|
|
||
| # Changelog since v2.4.0 | ||
|
|
||
| ## Changes by Kind | ||
|
|
||
| ### Feature | ||
|
|
||
| - Windows images for ltsc2022 ([#129](https://github.com/kubernetes-csi/livenessprobe/pull/129), [@mauriciopoppe](https://github.com/mauriciopoppe)) | ||
|
|
||
| ## Dependencies | ||
|
|
||
| ### Added | ||
| _Nothing has changed._ | ||
|
|
||
| ### Changed | ||
| _Nothing has changed._ | ||
|
|
||
| ### Removed | ||
| _Nothing has changed._ | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have we confirmed that the images are built correctly in staging?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The image is available in staging here: https://console.cloud.google.com/gcr/images/k8s-staging-sig-storage/global/livenessprobe@sha256:3660ab76b4d6ca6f834f089c621107e04f512309eada77703006ac5f040c3e32/details
Although I haven't run this image myself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I also saw that the image was generated but didn't try it in a cluster yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a Windows CI job with hostpath driver?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I know we only create Windows infra for the PD CSI Driver and SMB CSI Driver for their CI tests but we could add a similar config to the auto generated jobs in https://github.com/kubernetes/test-infra/blob/76f6d0e4c9/config/jobs/kubernetes-csi/gen-jobs.sh for Windows tests of the hostpath driver.
The sig-windows infra setup still doesn't have a CI tests for ltsc2022 to test this image exactly, we'd need help from Microsoft to test it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verification: #132 (comment)