Conversation
k8s-ci-robot
added
the
release-note-none
k8s-ci-robot
added
kind/documentation
k8s-ci-robot
added
the
size/S
|
/cc @mauriciopoppe |
|
|
||
| ### Feature | ||
|
|
||
| - Windows images for ltsc2022 ([#129](https://github.com/kubernetes-csi/livenessprobe/pull/129), [@mauriciopoppe](https://github.com/mauriciopoppe)) |
There was a problem hiding this comment.
Have we confirmed that the images are built correctly in staging?
There was a problem hiding this comment.
The image is available in staging here: https://console.cloud.google.com/gcr/images/k8s-staging-sig-storage/global/livenessprobe@sha256:3660ab76b4d6ca6f834f089c621107e04f512309eada77703006ac5f040c3e32/details
Although I haven't run this image myself.
There was a problem hiding this comment.
yeah I also saw that the image was generated but didn't try it in a cluster yet
There was a problem hiding this comment.
Do we have a Windows CI job with hostpath driver?
There was a problem hiding this comment.
As far as I know we only create Windows infra for the PD CSI Driver and SMB CSI Driver for their CI tests but we could add a similar config to the auto generated jobs in https://github.com/kubernetes/test-infra/blob/76f6d0e4c9/config/jobs/kubernetes-csi/gen-jobs.sh for Windows tests of the hostpath driver.
The sig-windows infra setup still doesn't have a CI tests for ltsc2022 to test this image exactly, we'd need help from Microsoft to test it.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msau42, verult The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
prow.sh: fix "on-master" prow jobs
6 participants
What type of PR is this?
/kind documentation
What this PR does / why we need it: 2.5.0 release prep (#132)
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
/assign @jsafrane @msau42 @xing-yang