Cherry-picks of #409 and #439: Adding --http-endpoint to snapshot components#511
Merged
k8s-ci-robot merged 2 commits intokubernetes-csi:release-3.1from May 3, 2021
chrishenzie:release-3.1-http-endpoint
Merged
Cherry-picks of #409 and #439: Adding --http-endpoint to snapshot components#511k8s-ci-robot merged 2 commits intokubernetes-csi:release-3.1from chrishenzie:release-3.1-http-endpoint
k8s-ci-robot merged 2 commits intokubernetes-csi:release-3.1from
chrishenzie:release-3.1-http-endpoint
Conversation
Signed-off-by: Grant Griffiths <grant@portworx.com>
xing-yang
reviewed
May 3, 2021
| metricsManager.SetDriverName(driverName) | ||
| go func() { | ||
| klog.Infof("ServeMux listening at %q", addr) | ||
| err := http.ListenAndServe(*metricsAddress, mux) |
Collaborator
There was a problem hiding this comment.
The following PR should be cherry-picked as well:
#497
It's fine to submit a follow-up for that.
Collaborator
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrishenzie, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
This PR contains cherry-picks of #409 and #439, which each provide an
--http-endpointflag for the snapshot-controller and csi-snapshotter.This is already present in v4; backporting so v3 users can make use of leader election health checks and have a consistent
--http-endpointflag across the snapshot-controller and csi-snapshotter.Does this PR introduce a user-facing change?:
/assign @xing-yang
I copied over the release notes from the two PRs.