Cherry-picks of #409 and #439: Adding --http-endpoint to snapshot components

[chrishenzie]

What type of PR is this?

/kind feature

What this PR does / why we need it:
This PR contains cherry-picks of #409 and #439, which each provide an --http-endpoint flag for the snapshot-controller and csi-snapshotter.

This is already present in v4; backporting so v3 users can make use of leader election health checks and have a consistent --http-endpoint flag across the snapshot-controller and csi-snapshotter.

Does this PR introduce a user-facing change?:

NONE

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chrishenzie
To complete the pull request process, please assign xing-yang after the PR has been reviewed.
You can assign the PR to them by writing /assign @xing-yang in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[chrishenzie]

/assign @jingxu97
/assign @ggriffiths
/assign @msau42

[xing-yang]

We don't backport new features to stable release branches.

[chrishenzie]

I see, is the target branch incorrect? What would be the best way to bring this feature into v3, or are you suggesting this is not possible at all?

[msau42]

@xing-yang in this case, leader-election check is a bug fix, and metrics should have been a beta requirement. Although I agree the snapshot-controller changes are very big so it is risky to put in a patch release. Should we consider making a new v3 minor release?

[xing-yang]

@xing-yang in this case, leader-election check is a bug fix, and metrics should have been a beta requirement. Although I agree the snapshot-controller changes are very big so it is risky to put in a patch release. Should we consider making a new v3 minor release?

We always cut minor release directly from master though. In this case, 4.0 is already out so we can't cut from master any more.

[msau42]

We could potentially cut from head of release-3.0

[xing-yang]

Issue opened here for discussions: kubernetes-csi/docs#419

[verult]

Gentle ping! I realized that the reset_timestamp fix for the CSI controller metrics csi_sidecar_operation_seconds is in csi-lib-utils 0.9.0, so snapshot operation metrics are broken in 3.x.

[xing-yang]

I think we are trying to wrap up discussions in the following PR. Once we're okay with that, we can make this change in the 3.1.0 release.
kubernetes-csi/docs#423

[chrishenzie]

@xing-yang Ready for merge on this PR

[xing-yang]

@chrishenzie We can't merge this as this is a backport to release-3.0. We need to cut a branch for release-3.1 first and then add this change there.

I'll be out for a few hours. I'll cut a release-3.1 branch when I'm back.

[xing-yang]

@chrishenzie A new branch release-3.1 is cut from release-3.0.
https://github.com/kubernetes-csi/external-snapshotter/tree/release-3.1

Can you close this PR and backport the changes to release-3.1?

[chrishenzie]

/close

@xing-yang Done, opened #511 for this work

[k8s-ci-robot]

@chrishenzie: Closed this PR.

Details

In response to this:

/close

@xing-yang Done, opened #511 for this work

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.