Skip to content

[WIP] Test PR jobs with release-tools/prow.sh snapshotter rbac fix#299

Closed
ggriffiths wants to merge 2 commits intokubernetes-csi:masterfrom
ggriffiths:test_snapshotter_rbac_pr_changes
Closed

[WIP] Test PR jobs with release-tools/prow.sh snapshotter rbac fix#299
ggriffiths wants to merge 2 commits intokubernetes-csi:masterfrom
ggriffiths:test_snapshotter_rbac_pr_changes

Conversation

@ggriffiths
Copy link
Copy Markdown
Contributor

@ggriffiths ggriffiths commented Apr 16, 2020

Signed-off-by: Grant Griffiths grant@portworx.com

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 16, 2020

@ggriffiths: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 16, 2020
@k8s-ci-robot k8s-ci-robot requested review from pohly and saad-ali April 16, 2020 02:21
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 16, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ggriffiths
To complete the pull request process, please assign lpabon
You can assign the PR to them by writing /assign @lpabon in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ggriffiths ggriffiths changed the title Test PR jobs with release-tools/prow.sh snapshotter rbac fix [WIP] Test PR jobs with release-tools/prow.sh snapshotter rbac fix Apr 16, 2020
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Apr 16, 2020
@ggriffiths ggriffiths mentioned this pull request Apr 16, 2020
Merged
ggriffiths
ggriffiths commented Apr 16, 2020
View reviewed changes
Comment thread release-tools/prow.sh Outdated
done

if [ -e deploy/kubernetes/rbac.yaml ]; then
if [ -e "$(pwd)/deploy/kubernetes/rbac.yaml" ] || [ -e "$(pwd)/deploy/kubernetes/csi-snapshotter/rbac-csi-snapshotter.yaml" ]; then
Copy link
Copy Markdown
Contributor Author

@ggriffiths ggriffiths Apr 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this check: if [ -e deploy/kubernetes/rbac.yaml ]; does not work without $(pwd), so this code path wasn't being executed. Also, we needed to adjust for the snapshot-controller by removing it from cmds

@ggriffiths ggriffiths force-pushed the test_snapshotter_rbac_pr_changes branch from 57b3b9c to 9fcefce Compare April 16, 2020 03:11
@ggriffiths ggriffiths mentioned this pull request Apr 16, 2020
Merged
@ggriffiths
Copy link
Copy Markdown
Contributor Author

ggriffiths commented Apr 16, 2020

/retest

1 similar comment
@ggriffiths
Copy link
Copy Markdown
Contributor Author

ggriffiths commented Apr 16, 2020

/retest

@ggriffiths ggriffiths mentioned this pull request Apr 16, 2020
Merged
@ggriffiths ggriffiths force-pushed the test_snapshotter_rbac_pr_changes branch 2 times, most recently from 9c01863 to b47d481 Compare April 20, 2020 07:21
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 20, 2020
@ggriffiths ggriffiths force-pushed the test_snapshotter_rbac_pr_changes branch from b47d481 to 1eb6fee Compare April 20, 2020 07:22
@ggriffiths
Add prow.sh test changes
74b554b 
Signed-off-by: Grant Griffiths <grant@portworx.com>
@ggriffiths ggriffiths force-pushed the test_snapshotter_rbac_pr_changes branch from 5e243a9 to 74b554b Compare April 20, 2020 20:04
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 20, 2020

@ggriffiths: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-csi-external-snapshotter-unit 74b554b link /test pull-kubernetes-csi-external-snapshotter-unit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ggriffiths ggriffiths closed this Apr 20, 2020
andyzhangx added a commit to andyzhangx/external-snapshotter that referenced this pull request Apr 17, 2026
@andyzhangx
Squashed 'release-tools/' changes from de06a09a7..909252797
9773a35 
909252797 Merge pull request kubernetes-csi#298 from torredil/trivy-schedule-trigger
2c9aed3e9 Merge pull request kubernetes-csi#299 from andyzhangx/patch-12
507ea1e90 chore: fix broken gcb-docker-gcloud image
ab1da0e96 Run Trivy scan on schedule instead of pull requests

git-subtree-dir: release-tools
git-subtree-split: 909252797a11793b90f81c1aff9d181b4eebd363
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pohly pohly Awaiting requested review from pohly

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ggriffiths @k8s-ci-robot