Skip to content

Re-enable k8s e2e tests in pull jobs#298

Merged
k8s-ci-robot merged 1 commit intokubernetes-csi:masterfrom
msau42:enable-e2es
Apr 23, 2020
Merged

Re-enable k8s e2e tests in pull jobs#298
k8s-ci-robot merged 1 commit intokubernetes-csi:masterfrom
msau42:enable-e2es

Conversation

@msau42
Copy link
Copy Markdown
Collaborator

@msau42 msau42 commented Apr 15, 2020

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
snapshotter pull jobs were misleading and not actually running the k8s e2e tests.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 15, 2020
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 15, 2020
@msau42
Copy link
Copy Markdown
Collaborator Author

msau42 commented Apr 15, 2020

@xing-yang @ggriffiths I think there are some problems with the way rbac rules are installed. Can you take a look?

@ggriffiths
Copy link
Copy Markdown
Contributor

ggriffiths commented Apr 15, 2020

@xing-yang @ggriffiths I think there are some problems with the way rbac rules are installed. Can you take a look?

Yes, taking a look now.

@ggriffiths ggriffiths mentioned this pull request Apr 16, 2020
Merged
@ggriffiths
Copy link
Copy Markdown
Contributor

ggriffiths commented Apr 16, 2020

@msau42 @xing-yang I have two PRs open to fix these tests:

  1. Fix for RBAC version: Fix csi-snapshotter RBAC yaml version csi-release-tools#78
  2. With the above fix, k8s 1.16 was still failing to deploy the hostpath driver. This fixes that problem:
    Fix deploy-hostpath.sh hostpath pod and CRD conditional for k8s 1.16 csi-driver-host-path#174

Both fixes are tested together in this PR (with your change from this PR)
#299

@msau42
Copy link
Copy Markdown
Collaborator Author

msau42 commented Apr 23, 2020

/retest

@xing-yang
Copy link
Copy Markdown
Collaborator

xing-yang commented Apr 23, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 23, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 23, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2020
@k8s-ci-robot k8s-ci-robot merged commit d6aa752 into kubernetes-csi:master Apr 23, 2020
@msau42 msau42 mentioned this pull request Apr 23, 2020
Merged
k8s-ci-robot added a commit that referenced this pull request Apr 23, 2020
@k8s-ci-robot
Merge pull request #302 from msau42/release-2.1
a2d5c6e 
Cherry pick of #298, #301: Re-enable k8s e2e tests
andyzhangx added a commit to andyzhangx/external-snapshotter that referenced this pull request Apr 17, 2026
@andyzhangx
Squashed 'release-tools/' changes from de06a09a7..909252797
9773a35 
909252797 Merge pull request kubernetes-csi#298 from torredil/trivy-schedule-trigger
2c9aed3e9 Merge pull request kubernetes-csi#299 from andyzhangx/patch-12
507ea1e90 chore: fix broken gcb-docker-gcloud image
ab1da0e96 Run Trivy scan on schedule instead of pull requests

git-subtree-dir: release-tools
git-subtree-split: 909252797a11793b90f81c1aff9d181b4eebd363
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xing-yang xing-yang Awaiting requested review from xing-yang

@yuxiangqian yuxiangqian Awaiting requested review from yuxiangqian

Assignees

@xing-yang xing-yang

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@msau42 @ggriffiths @xing-yang @k8s-ci-robot