tools: move lister and verifier to tools/ - #202
Conversation
|
Hi @iPraveenParihar. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
Integration tests failing because of certs expired, fixed by #203 |
|
|
||
| go build -o snapshot-metadata-lister ./examples/snapshot-metadata-lister/main.go | ||
| go build -o snapshot-metadata-verifier ./examples/snapshot-metadata-verifier/main.go | ||
| go build -o snapshot-metadata-lister ./tools/snapshot-metadata-lister/main.go |
There was a problem hiding this comment.
Can we keep the tools in examples repo?
There was a problem hiding this comment.
Can we keep the tools in examples repo?
we will end up with ambiguous import because Go finds the same package path in module cache: When examples/snapshot-metadata-verifier/go.mod requires github.com/kubernetes-csi/external-snapshot-metadata v0.2.0.
Since the published v0.2.0 module doesn't have a tools/ directory, there's no conflict, Go can only find it from the local go.mod.
Signed-off-by: Praveen M <m.praveen@ibm.com>
0135161 to
9168088
Compare
Rakshith-R
left a comment
There was a problem hiding this comment.
This change is required to complete k8s e2e suite
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iPraveenParihar, Rakshith-R The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Problem: Users cannot install the snapshot-metadata-lister and snapshot-metadata-verifier tools using go install due to the main module's replace directives:
Solution: Extract the tools into separate Go modules under tools/ directory. Each tool now has its own go.mod without any replace directives.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: