Do not log secret in log #82
Comments
|
I'll work on this! |
|
Instead of changing the logging, we could also just warn about this pitfall. It is limited to loglevel >= 5 (i.e. not the default). Note that the CSI example .yaml does use such a high log level, though. So there is definitely a risk that people accidentally log secrets. I'm undecided myself. Thoughts anyone? |
|
I got an idea, perhaps we can add a new argument |
6 tasks
pohly
added a commit
to pohly/external-provisioner
that referenced
this issue
Nov 21, 2018
When running at glog level >= 5, external-provisioner logged the full CreateVolumeRequest, including the secrets. Secrets should never be logged at any level to avoid accidentally exposing them. We need to filter out the secrets. With older CSI versions, that could have been done based on the field name, which is still an option should this get backported. With CSI 1.0, a custom field option marks fields as secret. Using that option has the advantage that the code will continue to work also when new secret fields get added in the future. For the sake of simplicity, JSON is now used as representation of the string instead of the former compact text format from gRPC. That makes it possible to strip values from a map with generic types, instead of having to copy and manipulate the real generated structures. Another option would have been to copy https://github.com/golang/protobuf/blob/master/proto/text.go and modify it so that it skips secret fields, but that's over 800 lines of code. Ultimately this new package should live in a "csi-common" repo and also include other utility code, like logGRPC itself. Fixes: kubernetes-csi#82, kubernetes-csi#167
Closed
Merged
This was referenced Jan 15, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://github.com/kubernetes-csi/external-provisioner/blob/v0.2.1/pkg/controller/controller.go#L89
This line will log 'controller_create_secrets' if present
The text was updated successfully, but these errors were encountered: