Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrub secrets 0.4 #111

Merged
merged 2 commits into from
Dec 19, 2018
Merged

Conversation

jarrpa
Copy link

@jarrpa jarrpa commented Dec 19, 2018

No description provided.

Signed-off-by: Jose A. Rivera <[email protected]>
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 19, 2018
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 19, 2018
@msau42
Copy link
Collaborator

msau42 commented Dec 19, 2018

Looks like go version used by travis is 1.10. You can update it to 1.11 here: https://github.com/kubernetes-csi/external-attacher/blob/master/.travis.yml

@msau42
Copy link
Collaborator

msau42 commented Dec 19, 2018

/assign

@jarrpa
Copy link
Author

jarrpa commented Dec 19, 2018

@msau42 Looks like it didn't like some whitespace changes that my editor made. I removed them and the go fmt is passing now.

@msau42
Copy link
Collaborator

msau42 commented Dec 19, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 19, 2018
@davidz627
Copy link
Contributor

/assign @saad-ali for approval

@k8s-ci-robot
Copy link
Contributor

@davidz627: GitHub didn't allow me to assign the following users: for, approval.

Note that only kubernetes-csi members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign @saad-ali for approval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@davidz627 davidz627 reopened this Dec 19, 2018
@saad-ali
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jarrpa, msau42, saad-ali

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 19, 2018
@k8s-ci-robot k8s-ci-robot merged commit 1e6a4a1 into kubernetes-csi:release-0.4 Dec 19, 2018
@msau42
Copy link
Collaborator

msau42 commented Jan 15, 2019

xing-yang added a commit that referenced this pull request Nov 14, 2020
5d874cce Merge pull request #112 from xing-yang/cleanup
79bbca7b Cleanup
d4376730 Merge pull request #111 from xing-yang/update_snapshot_v1_rc
57718f83 Update snapshot CRD version

git-subtree-dir: release-tools
git-subtree-split: 5d874cce4e649dfd254d01b9b44179ffa72aee75
@xing-yang xing-yang mentioned this pull request Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants