Skip to content

Skip VolumeAttachments of other drivers #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
k8s-ci-robot merged 1 commit into from
Sep 23, 2025
+5 −0
Merged

Skip VolumeAttachments of other drivers #682

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pkg/controller/csi_handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,11 @@ func (h *csiHandler) ReconcileVA(ctx context.Context) error {
}

for _, va := range vas {
if va.Spec.Attacher != h.attacherName {
// skip VolumeAttachments of other CSI drivers
continue
}

Copy link
Copy Markdown
Contributor

@gnufied gnufied Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tut tut - tests.:-)

Copy link
Copy Markdown
Contributor Author

@jsafrane jsafrane Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried! But the test framework runs ReconcileVA() in a loop and it's hard to check just the first ReconcileVA result :-(

nodeID, err := h.getNodeID(logger, h.attacherName, va.Spec.NodeName, va)
if err != nil {
logger.Error(err, "Failed to find node ID err")
Expand Down