Skip VolumeAttachments of other drivers#682
Merged
k8s-ci-robot merged 1 commit intokubernetes-csi:masterfrom Sep 23, 2025
Merged
Skip VolumeAttachments of other drivers#682k8s-ci-robot merged 1 commit intokubernetes-csi:masterfrom
k8s-ci-robot merged 1 commit intokubernetes-csi:masterfrom
Conversation
During periodic re-sync in ReconcileVA, skip VolumeAttachments of unrelated CSI drivers. The VolumeAttachments will be skipped anyway in syncVA(). This only prevents log spam and saves some CPU.
k8s-ci-robot
added
release-note
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
gnufied
reviewed
Sep 23, 2025
| // skip VolumeAttachments of other CSI drivers | ||
| continue | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
I tried! But the test framework runs ReconcileVA() in a loop and it's hard to check just the first ReconcileVA result :-(
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
Fix included in accepted release 4.21.0-0.nightly-2025-10-02-002727 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
During periodic re-sync in
ReconcileVA, skip VolumeAttachments of unrelated CSI drivers. These unrelated VolumeAttachments would be skipped anyway insyncVA().This only prevents log spam and saves some CPU.
Which issue(s) this PR fixes:
Fixes #681
Does this PR introduce a user-facing change?: