Add configurable throughput parameters for clients to API server#286
Merged
k8s-ci-robot merged 1 commit intokubernetes-csi:masterfrom Jan 4, 2021
Merged
Add configurable throughput parameters for clients to API server#286k8s-ci-robot merged 1 commit intokubernetes-csi:masterfrom
k8s-ci-robot merged 1 commit intokubernetes-csi:masterfrom
Conversation
k8s-ci-robot
added
release-note
Contributor
Author
|
/assign @msau42 |
k8s-ci-robot
added
the
size/S
RaunakShah
force-pushed
the
throughput
branch
from
3f2d32a to
2e1d299
Compare
k8s-ci-robot
added
size/XS
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane, RaunakShah The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
dfajmon
added a commit
to dfajmon/csi-external-attacher
that referenced
this pull request
Jan 12, 2026
d6846630bd1 Merge pull request kubernetes-csi#290 from dfajmon/go-1.25.5 55e527c4947 Bump golang to 1.25.5 b12e407cc95 Merge pull request kubernetes-csi#289 from nixpanic/k8s-v1.34 bbe5e547e2d Use Kubernetes v1.34 and Kind v0.30 by default 4e9eb2c9ee5 Merge pull request kubernetes-csi#288 from gnufied/add-gnufied-for-csi-approver 064e260d995 Add myself as csi approver c852fa797fe Merge pull request kubernetes-csi#287 from andyzhangx/patch-7 bce16c103a9 fix: upgrade to go1.24.11 to fix CVE-2025-61727 8d1258cce80 Merge pull request kubernetes-csi#286 from kubernetes-csi/dependabot/github_actions/actions/checkout-6 91e35981a64 Bump actions/checkout from 5 to 6 294138155cf Merge pull request kubernetes-csi#285 from andyzhangx/patch-6 fa8b339e900 fix: upgrade to go1.24.9 to fix CVEs 74502e544bc Merge pull request kubernetes-csi#278 from liangyuanpeng/migrate_k8s_testimages 53344305509 Merge pull request kubernetes-csi#281 from kubernetes-csi/dependabot/github_actions/actions/checkout-5 458ce146ff7 Bump actions/checkout from 4 to 5 5ec1a52b84d use gcr.io/k8s-staging-test-infra instead of gcr.io/k8s-testimages git-subtree-dir: release-tools git-subtree-split: d6846630bd10e563861ab5fa870f9b815daf1f61
dfajmon
added a commit
to dfajmon/csi-external-attacher
that referenced
this pull request
Jan 13, 2026
707a99ecae0 Merge pull request kubernetes-csi#291 from dfajmon/logcheck a9d2b0fb3b0 Bump logcheck to v0.10.0 d6846630bd1 Merge pull request kubernetes-csi#290 from dfajmon/go-1.25.5 55e527c4947 Bump golang to 1.25.5 b12e407cc95 Merge pull request kubernetes-csi#289 from nixpanic/k8s-v1.34 bbe5e547e2d Use Kubernetes v1.34 and Kind v0.30 by default 4e9eb2c9ee5 Merge pull request kubernetes-csi#288 from gnufied/add-gnufied-for-csi-approver 064e260d995 Add myself as csi approver c852fa797fe Merge pull request kubernetes-csi#287 from andyzhangx/patch-7 bce16c103a9 fix: upgrade to go1.24.11 to fix CVE-2025-61727 8d1258cce80 Merge pull request kubernetes-csi#286 from kubernetes-csi/dependabot/github_actions/actions/checkout-6 91e35981a64 Bump actions/checkout from 5 to 6 294138155cf Merge pull request kubernetes-csi#285 from andyzhangx/patch-6 fa8b339e900 fix: upgrade to go1.24.9 to fix CVEs 74502e544bc Merge pull request kubernetes-csi#278 from liangyuanpeng/migrate_k8s_testimages 53344305509 Merge pull request kubernetes-csi#281 from kubernetes-csi/dependabot/github_actions/actions/checkout-5 458ce146ff7 Bump actions/checkout from 4 to 5 5ec1a52b84d use gcr.io/k8s-staging-test-infra instead of gcr.io/k8s-testimages git-subtree-dir: release-tools git-subtree-split: 707a99ecae026a8faa36d60aa9ea88505b5865df
DerekFrank
pushed a commit
to DerekFrank/external-attacher
that referenced
this pull request
Jan 27, 2026
707a99ecae0 Merge pull request kubernetes-csi#291 from dfajmon/logcheck a9d2b0fb3b0 Bump logcheck to v0.10.0 d6846630bd1 Merge pull request kubernetes-csi#290 from dfajmon/go-1.25.5 55e527c4947 Bump golang to 1.25.5 b12e407cc95 Merge pull request kubernetes-csi#289 from nixpanic/k8s-v1.34 bbe5e547e2d Use Kubernetes v1.34 and Kind v0.30 by default 4e9eb2c9ee5 Merge pull request kubernetes-csi#288 from gnufied/add-gnufied-for-csi-approver 064e260d995 Add myself as csi approver c852fa797fe Merge pull request kubernetes-csi#287 from andyzhangx/patch-7 bce16c103a9 fix: upgrade to go1.24.11 to fix CVE-2025-61727 8d1258cce80 Merge pull request kubernetes-csi#286 from kubernetes-csi/dependabot/github_actions/actions/checkout-6 91e35981a64 Bump actions/checkout from 5 to 6 294138155cf Merge pull request kubernetes-csi#285 from andyzhangx/patch-6 fa8b339e900 fix: upgrade to go1.24.9 to fix CVEs 74502e544bc Merge pull request kubernetes-csi#278 from liangyuanpeng/migrate_k8s_testimages 53344305509 Merge pull request kubernetes-csi#281 from kubernetes-csi/dependabot/github_actions/actions/checkout-5 458ce146ff7 Bump actions/checkout from 4 to 5 5ec1a52b84d use gcr.io/k8s-staging-test-infra instead of gcr.io/k8s-testimages git-subtree-dir: release-tools git-subtree-split: 707a99ecae026a8faa36d60aa9ea88505b5865df
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Similar to other sidecars, this PR adds configurable QPS and Burst as a command line option to exteral-attacher.
Testing:
Test is to use 64 threads to create and delete pods. With different values for QPS/Burst, the DeletePod throughput varies as shown:
QPS=5 (default) => 2.5 ops/sec
QPS=25 => 4.5 ops/sec
QPS=100 => 4.8 ops/sec
These tests were carried out on a k8s cluster with a modified version of VMware's CSI driver for simulation. However the numbers show that an increase in QPS helps with increasing throughput.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: