Skip to content

Fix metrics endpoint initialization#278

Merged
k8s-ci-robot merged 1 commit intokubernetes-csi:masterfrom
jsafrane:fix-metrics
Nov 23, 2020
Merged

Fix metrics endpoint initialization#278
k8s-ci-robot merged 1 commit intokubernetes-csi:masterfrom
jsafrane:fix-metrics

Conversation

@jsafrane
Copy link
Copy Markdown
Contributor

@jsafrane jsafrane commented Nov 23, 2020

Don't initialize a second CSIMetricsManager, use the one already created.
/kind bug

Inspired by kubernetes-csi/external-health-monitor#46, thanks @pohly for spotting this.

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 23, 2020
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 23, 2020
pohly
pohly reviewed Nov 23, 2020
View reviewed changes
Comment thread cmd/csi-attacher/main.go
}()
if *metricsAddress != "" {
metricsManager.RegisterToServer(mux, *metricsPath)
go func() {
Copy link
Copy Markdown
Contributor

@pohly pohly Nov 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to restore the metricsManager.SetDriverName(csiAttacher) line above.

@jsafrane
Fix metrics endpoint initialization
a8f25c7 
Don't initialize a second CSIMetricsManager, use the one already created.
pohly
pohly approved these changes Nov 23, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 23, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 23, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c09bf1a into kubernetes-csi:master Nov 23, 2020
dfajmon added a commit to dfajmon/csi-external-attacher that referenced this pull request Jan 12, 2026
@dfajmon
Squashed 'release-tools/' changes from 5f38a907597..d6846630bd1
14f930c 
d6846630bd1 Merge pull request kubernetes-csi#290 from dfajmon/go-1.25.5
55e527c4947 Bump golang to 1.25.5
b12e407cc95 Merge pull request kubernetes-csi#289 from nixpanic/k8s-v1.34
bbe5e547e2d Use Kubernetes v1.34 and Kind v0.30 by default
4e9eb2c9ee5 Merge pull request kubernetes-csi#288 from gnufied/add-gnufied-for-csi-approver
064e260d995 Add myself as csi approver
c852fa797fe Merge pull request kubernetes-csi#287 from andyzhangx/patch-7
bce16c103a9 fix: upgrade to go1.24.11 to fix CVE-2025-61727
8d1258cce80 Merge pull request kubernetes-csi#286 from kubernetes-csi/dependabot/github_actions/actions/checkout-6
91e35981a64 Bump actions/checkout from 5 to 6
294138155cf Merge pull request kubernetes-csi#285 from andyzhangx/patch-6
fa8b339e900 fix: upgrade to go1.24.9 to fix CVEs
74502e544bc Merge pull request kubernetes-csi#278 from liangyuanpeng/migrate_k8s_testimages
53344305509 Merge pull request kubernetes-csi#281 from kubernetes-csi/dependabot/github_actions/actions/checkout-5
458ce146ff7 Bump actions/checkout from 4 to 5
5ec1a52b84d use gcr.io/k8s-staging-test-infra instead of gcr.io/k8s-testimages

git-subtree-dir: release-tools
git-subtree-split: d6846630bd10e563861ab5fa870f9b815daf1f61
dfajmon added a commit to dfajmon/csi-external-attacher that referenced this pull request Jan 13, 2026
@dfajmon
Squashed 'release-tools/' changes from 5f38a907597..707a99ecae0
8174d14 
707a99ecae0 Merge pull request kubernetes-csi#291 from dfajmon/logcheck
a9d2b0fb3b0 Bump logcheck to v0.10.0
d6846630bd1 Merge pull request kubernetes-csi#290 from dfajmon/go-1.25.5
55e527c4947 Bump golang to 1.25.5
b12e407cc95 Merge pull request kubernetes-csi#289 from nixpanic/k8s-v1.34
bbe5e547e2d Use Kubernetes v1.34 and Kind v0.30 by default
4e9eb2c9ee5 Merge pull request kubernetes-csi#288 from gnufied/add-gnufied-for-csi-approver
064e260d995 Add myself as csi approver
c852fa797fe Merge pull request kubernetes-csi#287 from andyzhangx/patch-7
bce16c103a9 fix: upgrade to go1.24.11 to fix CVE-2025-61727
8d1258cce80 Merge pull request kubernetes-csi#286 from kubernetes-csi/dependabot/github_actions/actions/checkout-6
91e35981a64 Bump actions/checkout from 5 to 6
294138155cf Merge pull request kubernetes-csi#285 from andyzhangx/patch-6
fa8b339e900 fix: upgrade to go1.24.9 to fix CVEs
74502e544bc Merge pull request kubernetes-csi#278 from liangyuanpeng/migrate_k8s_testimages
53344305509 Merge pull request kubernetes-csi#281 from kubernetes-csi/dependabot/github_actions/actions/checkout-5
458ce146ff7 Bump actions/checkout from 4 to 5
5ec1a52b84d use gcr.io/k8s-staging-test-infra instead of gcr.io/k8s-testimages

git-subtree-dir: release-tools
git-subtree-split: 707a99ecae026a8faa36d60aa9ea88505b5865df
DerekFrank pushed a commit to DerekFrank/external-attacher that referenced this pull request Jan 27, 2026
@dfajmon @DerekFrank
Squashed 'release-tools/' changes from 5f38a907597..707a99ecae0
29421ff 
707a99ecae0 Merge pull request kubernetes-csi#291 from dfajmon/logcheck
a9d2b0fb3b0 Bump logcheck to v0.10.0
d6846630bd1 Merge pull request kubernetes-csi#290 from dfajmon/go-1.25.5
55e527c4947 Bump golang to 1.25.5
b12e407cc95 Merge pull request kubernetes-csi#289 from nixpanic/k8s-v1.34
bbe5e547e2d Use Kubernetes v1.34 and Kind v0.30 by default
4e9eb2c9ee5 Merge pull request kubernetes-csi#288 from gnufied/add-gnufied-for-csi-approver
064e260d995 Add myself as csi approver
c852fa797fe Merge pull request kubernetes-csi#287 from andyzhangx/patch-7
bce16c103a9 fix: upgrade to go1.24.11 to fix CVE-2025-61727
8d1258cce80 Merge pull request kubernetes-csi#286 from kubernetes-csi/dependabot/github_actions/actions/checkout-6
91e35981a64 Bump actions/checkout from 5 to 6
294138155cf Merge pull request kubernetes-csi#285 from andyzhangx/patch-6
fa8b339e900 fix: upgrade to go1.24.9 to fix CVEs
74502e544bc Merge pull request kubernetes-csi#278 from liangyuanpeng/migrate_k8s_testimages
53344305509 Merge pull request kubernetes-csi#281 from kubernetes-csi/dependabot/github_actions/actions/checkout-5
458ce146ff7 Bump actions/checkout from 4 to 5
5ec1a52b84d use gcr.io/k8s-staging-test-infra instead of gcr.io/k8s-testimages

git-subtree-dir: release-tools
git-subtree-split: 707a99ecae026a8faa36d60aa9ea88505b5865df
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidz627 davidz627 Awaiting requested review from davidz627

@saad-ali saad-ali Awaiting requested review from saad-ali

1 more reviewer

@pohly pohly pohly approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@pohly pohly

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jsafrane @k8s-ci-robot @pohly