release-2.2: update release-tools#257
Merged
k8s-ci-robot merged 44 commits intokubernetes-csi:release-2.2from Oct 6, 2020
Merged
release-2.2: update release-tools#257k8s-ci-robot merged 44 commits intokubernetes-csi:release-2.2from
k8s-ci-robot merged 44 commits intokubernetes-csi:release-2.2from
Conversation
Developers should not be forced to build for all platforms by default. We also don't want to copy-and-paste the go invocation for each new platform. To address both, the target platform(s) are now configurable via BUILD_PLATFORMS and additional platforms are only enabled in the Prow CI. For now this serves as a test that the source actually compiles for multiple platforms. Building images for different target platforms is a different problem.
build for multiple platforms only in CI, add s390x
Signed-off-by: Grant Griffiths <grant@portworx.com>
…pdate Update snapshotter to version 2.0.1
update release tools instructions
Signed-off-by: Grant Griffiths <grant@portworx.com>
…ter_rbac_version_set Fix csi-snapshotter RBAC yaml version
Update patch release notes generation command
The approach taken here extends the existing support for cross-compiling binaries on the build host and specifying the Go compiler: Go is installed if needed (as in Prow testing), binaries are build on the host, then one image is created for each platform, and finally those are combined into a single multi-architecture image.
cloud build: initial set of shared files
"make push-multiarch" matched both push-multiarch and push-%. This seems to be none-deterministic and in at least one repo (external-provisioner), make picked the wildcard rule which then failed because there is no "multiarch" command. This ambiguity gets resolved by instantiating the wildcard rules only for existing commands. The advantage also is that "make push-no-such-command" will fail with an obvious "No rule to make target 'push-no-such-command'" instead of attempting to build the command.
It's not a real file and thus should better be marked as phony.
Most repos inherit the default BUILD_PLATFORMS, which includes Windows, but don't have the necessary Dockerfile.Windows yet. To simplify the rollout of multiarch image builds, Windows binary building continues to be tested (i.e. BUILD_PLATFORMS remains unchanged), but push-multiarch skips Windows if the Dockerfile.Windows is missing.
multiarch windows fix
If the Dockerfile needs to run some command, that step fails unless
QEMU is set up properly first:
failed to solve: rpc error: code = Unknown desc = failed to load
LLB: runtime execution on platform linux/ppc64le not supported
cloud build: initialize support for running commands in Dockerfile
As discussed in kubernetes/k8s.io#943, we want to consolidate under k8s-staging-sig-storage.
cloud build: k8s-staging-sig-storage
prow.sh: enable building arm64 image
Signed-off-by: Animesh Kumar <animuz111@gmail.com>
filter-junit: Fix golint error
Signed-off-by: Animesh Kumar <animuz111@gmail.com>
filter-junit: Fix gofmt error
cloud build: bump timeout in Prow job
Add steps on promoting release images
Go 1.15 was released and is the major version that Kubernetes 1.19.0 is going to use. There are probably bugs in the older 1.13.3 that were fixed, so we should update.
switch to Go 1.15
Kubernetes 1.19.0 uses Go 1.15, but refers to it as 1.15.0. This broke both the check whether we need to install 1.15 (because "go version" reports 1.15, which didn't match 1.15.0) and then downloading the release archive (because the URL also only uses 1.15).
It used to be necessary to override from where the E2E suite came on a case-by-case basis (initially, testing was using a more recent suite against an older Kubernetes). This should never become necessary again and the lack of a specific entry for 1.18 already had the unintended effect that Kubernetes 1.18 was tested with the suite from master, so overall it is better to always use the E2E suite which matches Kubernetes.
Kubernetes 1.19 fixes
Use staging registry for canary tests
Update release process
Only set staging registry when running canary job
Commit summary: 7100c12 Only set staging registry when running canary job d129462 Document new method for adding CI jobs are new K8s versions e73c2ce Use staging registry for canary tests 2c09846 Add cleanup instructions to release-notes generation 0979c09 prow.sh: fix E2E suite for Kubernetes >= 1.18 3b4a2f1 prow.sh: fix installing Go for Kubernetes 1.19.0 82d108a switch to Go 1.15 843bddc Add steps on promoting release images 1fdf2d5 cloud build: bump timeout in Prow job 5a54e67 filter-junit: Fix gofmt error 36ea4ff filter-junit: Fix golint error 43e50d6 prow.sh: enable building arm64 image 3df86b7 cloud build: k8s-staging-sig-storage db0c2a7 cloud build: initialize support for running commands in Dockerfile 340e082 build.make: optional inclusion of Windows in multiarch images 5231f05 build.make: properly declare push-multiarch 4569f27 build.make: fix push-multiarch ambiguity bd41690 cloud build: initial set of shared files 6f2322e Update patch release notes generation command d8c76fe Support local snapshot RBAC for pull jobs ea1f94a update release tools instructions 7edc146 Update snapshotter to version 2.0.1 3863a0f build for multiple platforms only in CI, add s390x
k8s-ci-robot
added
the
release-note-none
k8s-ci-robot
added
cncf-cla: yes
Collaborator
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jiawei0227, msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
dfajmon
pushed a commit
to dfajmon/csi-external-attacher
that referenced
this pull request
Aug 14, 2024
988496a1 Merge pull request kubernetes-csi#257 from jakobmoellerdev/csi-prow-sidecar-e2e-path 028f8c69 chore: bump to Go 1.22.5 69bd71e8 chore: add CSI_PROW_SIDECAR_E2E_PATH f40f0ccd Merge pull request kubernetes-csi#256 from solumath/master cfa92106 Instruction update 379a1bb9 Merge pull request kubernetes-csi#255 from humblec/sidecar-md a5667bbb fix typo in sidecar release process 49676850 Merge pull request kubernetes-csi#254 from bells17/add-github-actions d9bd160c Update skip list in codespell GitHub Action f5aebfc9 Add GitHub Actions workflows git-subtree-dir: release-tools git-subtree-split: 988496a1fc3849ed793e03012fdd56813d13d46c
dfajmon
added a commit
to dfajmon/csi-external-attacher
that referenced
this pull request
Aug 14, 2024
988496a1 Merge pull request kubernetes-csi#257 from jakobmoellerdev/csi-prow-sidecar-e2e-path 028f8c69 chore: bump to Go 1.22.5 69bd71e8 chore: add CSI_PROW_SIDECAR_E2E_PATH f40f0ccd Merge pull request kubernetes-csi#256 from solumath/master cfa92106 Instruction update 379a1bb9 Merge pull request kubernetes-csi#255 from humblec/sidecar-md a5667bbb fix typo in sidecar release process 49676850 Merge pull request kubernetes-csi#254 from bells17/add-github-actions d9bd160c Update skip list in codespell GitHub Action f5aebfc9 Add GitHub Actions workflows git-subtree-dir: release-tools git-subtree-split: 988496a1fc3849ed793e03012fdd56813d13d46c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit summary:
7100c12 Only set staging registry when running canary job
d129462 Document new method for adding CI jobs are new K8s versions
e73c2ce Use staging registry for canary tests
2c09846 Add cleanup instructions to release-notes generation
0979c09 prow.sh: fix E2E suite for Kubernetes >= 1.18
3b4a2f1 prow.sh: fix installing Go for Kubernetes 1.19.0
82d108a switch to Go 1.15
843bddc Add steps on promoting release images
1fdf2d5 cloud build: bump timeout in Prow job
5a54e67 filter-junit: Fix gofmt error
36ea4ff filter-junit: Fix golint error
43e50d6 prow.sh: enable building arm64 image
3df86b7 cloud build: k8s-staging-sig-storage
db0c2a7 cloud build: initialize support for running commands in Dockerfile
340e082 build.make: optional inclusion of Windows in multiarch images
5231f05 build.make: properly declare push-multiarch
4569f27 build.make: fix push-multiarch ambiguity
bd41690 cloud build: initial set of shared files
6f2322e Update patch release notes generation command
d8c76fe Support local snapshot RBAC for pull jobs
ea1f94a update release tools instructions
7edc146 Update snapshotter to version 2.0.1
3863a0f build for multiple platforms only in CI, add s390x