Skip to content

Upgrade csi-lib-utils to 0.7.1#255

Closed
Jiawei0227 wants to merge 1 commit intokubernetes-csi:release-2.2from
Jiawei0227:release-2.2
Closed

Upgrade csi-lib-utils to 0.7.1#255
Jiawei0227 wants to merge 1 commit intokubernetes-csi:release-2.2from
Jiawei0227:release-2.2

Conversation

@Jiawei0227
Copy link
Copy Markdown
Contributor

@Jiawei0227 Jiawei0227 commented Oct 6, 2020

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Upgrade the csi-lib-utils to have process_start_time_seconds metric so that the metric can be correctly parsed.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Include `process_start_time_seconds` metric in the endpoint.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 6, 2020
@Jiawei0227
Copy link
Copy Markdown
Contributor Author

Jiawei0227 commented Oct 6, 2020

/cc @msau42

@k8s-ci-robot k8s-ci-robot requested a review from msau42 October 6, 2020 17:53
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 6, 2020
@msau42
Copy link
Copy Markdown
Collaborator

msau42 commented Oct 6, 2020

/lgtm
/approve
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 6, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 6, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jiawei0227, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2020
@Jiawei0227
Copy link
Copy Markdown
Contributor Author

Jiawei0227 commented Oct 6, 2020

The tests are failing in an unexpected way...

@msau42
Copy link
Copy Markdown
Collaborator

msau42 commented Oct 6, 2020

Oh... we need to update release-tools to get go1.15 support

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 6, 2020

@Jiawei0227: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-csi-external-attacher-1-19-on-kubernetes-1-19 658be1a link /test pull-kubernetes-csi-external-attacher-1-19-on-kubernetes-1-19
pull-kubernetes-csi-external-attacher-1-18-on-kubernetes-1-18 658be1a link /test pull-kubernetes-csi-external-attacher-1-18-on-kubernetes-1-18

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Jiawei0227
Copy link
Copy Markdown
Contributor Author

Jiawei0227 commented Oct 6, 2020

closed as automatically included by https://github.com/kubernetes-csi/external-attacher/pull/257/files already

@Jiawei0227 Jiawei0227 closed this Oct 6, 2020
dfajmon pushed a commit to dfajmon/csi-external-attacher that referenced this pull request Aug 14, 2024
@solumath
Squashed 'release-tools/' changes from adb3af9d..988496a1
f72f921 
988496a1 Merge pull request kubernetes-csi#257 from jakobmoellerdev/csi-prow-sidecar-e2e-path
028f8c69 chore: bump to Go 1.22.5
69bd71e8 chore: add CSI_PROW_SIDECAR_E2E_PATH
f40f0ccd Merge pull request kubernetes-csi#256 from solumath/master
cfa92106 Instruction update
379a1bb9 Merge pull request kubernetes-csi#255 from humblec/sidecar-md
a5667bbb fix typo in sidecar release process
49676850 Merge pull request kubernetes-csi#254 from bells17/add-github-actions
d9bd160c Update skip list in codespell GitHub Action
f5aebfc9 Add GitHub Actions workflows

git-subtree-dir: release-tools
git-subtree-split: 988496a1fc3849ed793e03012fdd56813d13d46c
dfajmon added a commit to dfajmon/csi-external-attacher that referenced this pull request Aug 14, 2024
@dfajmon
Squashed 'release-tools/' changes from adb3af9d..988496a1
6d406c8 
988496a1 Merge pull request kubernetes-csi#257 from jakobmoellerdev/csi-prow-sidecar-e2e-path
028f8c69 chore: bump to Go 1.22.5
69bd71e8 chore: add CSI_PROW_SIDECAR_E2E_PATH
f40f0ccd Merge pull request kubernetes-csi#256 from solumath/master
cfa92106 Instruction update
379a1bb9 Merge pull request kubernetes-csi#255 from humblec/sidecar-md
a5667bbb fix typo in sidecar release process
49676850 Merge pull request kubernetes-csi#254 from bells17/add-github-actions
d9bd160c Update skip list in codespell GitHub Action
f5aebfc9 Add GitHub Actions workflows

git-subtree-dir: release-tools
git-subtree-split: 988496a1fc3849ed793e03012fdd56813d13d46c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidz627 davidz627 Awaiting requested review from davidz627

@saad-ali saad-ali Awaiting requested review from saad-ali

@msau42 msau42 Awaiting requested review from msau42

Assignees

@msau42 msau42

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Jiawei0227 @msau42 @k8s-ci-robot