Skip to content

Upgrade csi-lib-utils to 0.8.1#253

Merged
k8s-ci-robot merged 2 commits intokubernetes-csi:masterfrom
Jiawei0227:csilibupgrade
Oct 2, 2020
Merged

Upgrade csi-lib-utils to 0.8.1#253
k8s-ci-robot merged 2 commits intokubernetes-csi:masterfrom
Jiawei0227:csilibupgrade

Conversation

@Jiawei0227
Copy link
Copy Markdown
Contributor

@Jiawei0227 Jiawei0227 commented Oct 2, 2020

What type of PR is this?
/kind feature

What this PR does / why we need it:
Upgrade csi-lib-utils to version 0.8.1

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add `process_start_time_seconds` metric.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 2, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 2, 2020

Welcome @Jiawei0227!

It looks like this is your first PR to kubernetes-csi/external-attacher 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/external-attacher has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 2, 2020

Hi @Jiawei0227. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 2, 2020
@msau42
Copy link
Copy Markdown
Collaborator

msau42 commented Oct 2, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 2, 2020
@Jiawei0227
Copy link
Copy Markdown
Contributor Author

Jiawei0227 commented Oct 2, 2020

/retest

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 2, 2020 •
edited
Loading

@Jiawei0227: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-csi-external-attacher-1-19-on-kubernetes-1-19 1344c83 link /test pull-kubernetes-csi-external-attacher-1-19-on-kubernetes-1-19

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 2, 2020
@msau42
Copy link
Copy Markdown
Collaborator

msau42 commented Oct 2, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 2, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 2, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jiawei0227, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2020
@k8s-ci-robot k8s-ci-robot merged commit 0bed2c1 into kubernetes-csi:master Oct 2, 2020
jsafrane added a commit to jsafrane/external-attacher that referenced this pull request May 13, 2024
@jsafrane
Squashed 'release-tools/' changes from dc4d0ae2..adb3af9d
3ce7ba6 
adb3af9d Merge pull request kubernetes-csi#252 from bells17/update-go-version
b82ee388 Merge pull request kubernetes-csi#253 from bells17/fix-typo
c3174562 Fix typo
0a785056 Bump to Go 1.22.3
edd89ad5 Merge pull request kubernetes-csi#251 from jsafrane/add-logcheck
043fd099 Add test-logcheck target
d7535ae0 Merge pull request kubernetes-csi#250 from jsafrane/go-1.22
b52e7ad3 Update go to 1.22.2
14fdb6f6 Merge pull request kubernetes-csi#247 from msau42/prow
9b4352e9 Update release playbook
c7bb972c Fix release notes script to use fixed tags
463a0e9f Add script to update specific go modules

git-subtree-dir: release-tools
git-subtree-split: adb3af9dfa3ed4d1a922cd839bb48e0b73918617
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidz627 davidz627 Awaiting requested review from davidz627

@lpabon lpabon Awaiting requested review from lpabon

Assignees

@msau42 msau42

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Jiawei0227 @k8s-ci-robot @msau42