Skip to content

Bump go version to 1.15#250

Merged
k8s-ci-robot merged 1 commit intokubernetes-csi:masterfrom
humblec:go-spec
Aug 28, 2020
Merged

Bump go version to 1.15#250
k8s-ci-robot merged 1 commit intokubernetes-csi:masterfrom
humblec:go-spec

Conversation

@humblec
Copy link
Copy Markdown
Contributor

@humblec humblec commented Aug 25, 2020

Signed-off-by: Humble Chirammal hchiramm@redhat.com

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@humblec
Bump go version to 1.15
8d4b631 
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 25, 2020
@humblec
Copy link
Copy Markdown
Contributor Author

humblec commented Aug 25, 2020

/release-note-none

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 25, 2020
@humblec
Copy link
Copy Markdown
Contributor Author

humblec commented Aug 25, 2020

/assign @jsafrane
/assign @msau42

@msau42
Copy link
Copy Markdown
Collaborator

msau42 commented Aug 28, 2020

/lgtm
/approve
/hold
Can you add a release note?

Also this will probably need rebasing after #251 merges

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Aug 28, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 28, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: humblec, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2020
@pohly
Copy link
Copy Markdown
Contributor

pohly commented Aug 28, 2020

Can you add a release note?

"Build with Go 1.15" was already added as release note via #245

As far as I understand it, bumping the version in go.mod has no real impact. I tried with some other repo and it still built fine also with older Go, so Go isn't even enforcing the minimal version. At best it provides some hints. There's an open bug about this vagueness: golang/go#30791

@pohly
Copy link
Copy Markdown
Contributor

pohly commented Aug 28, 2020

Having said that, Go 1.15 is what we use for testing and building, so specifying that in the go.mod file seems reasonable to me.

lgtm

@msau42
Copy link
Copy Markdown
Collaborator

msau42 commented Aug 28, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 28, 2020
@k8s-ci-robot k8s-ci-robot merged commit 322c860 into kubernetes-csi:master Aug 28, 2020
jsafrane added a commit to jsafrane/external-attacher that referenced this pull request May 13, 2024
@jsafrane
Squashed 'release-tools/' changes from dc4d0ae2..adb3af9d
3ce7ba6 
adb3af9d Merge pull request kubernetes-csi#252 from bells17/update-go-version
b82ee388 Merge pull request kubernetes-csi#253 from bells17/fix-typo
c3174562 Fix typo
0a785056 Bump to Go 1.22.3
edd89ad5 Merge pull request kubernetes-csi#251 from jsafrane/add-logcheck
043fd099 Add test-logcheck target
d7535ae0 Merge pull request kubernetes-csi#250 from jsafrane/go-1.22
b52e7ad3 Update go to 1.22.2
14fdb6f6 Merge pull request kubernetes-csi#247 from msau42/prow
9b4352e9 Update release playbook
c7bb972c Fix release notes script to use fixed tags
463a0e9f Add script to update specific go modules

git-subtree-dir: release-tools
git-subtree-split: adb3af9dfa3ed4d1a922cd839bb48e0b73918617
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidz627 davidz627 Awaiting requested review from davidz627

@msau42 msau42 Awaiting requested review from msau42

Assignees

@jsafrane jsafrane

@msau42 msau42

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@humblec @msau42 @k8s-ci-robot @pohly @jsafrane