1.2: Fixed ControllerUnpublish error handling#168
1.2: Fixed ControllerUnpublish error handling#168k8s-ci-robot merged 2 commits intokubernetes-csi:release-1.2from
Conversation
Any error from ControllerUnpublish can mean that a volume could be still attached (or being detached).
The attacher should retry ControllerUnpublish after error. At the same time, we do not want to change behavior of NotFound handling in stable branches, so treat it as no error.
k8s-ci-robot
added
release-note
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
In which csi-attacher image tag this fix is available? This If its only inside image tag Thanks a lot |
|
Sorry about that, 1.2.1 was released ~1 month ago and it should be fixed there. The version is spread among too many files :-( |
|
Can you please clarify. is v1.2.1 image was released as GAed version that is also compatible with k8s 1.13? thanks a lot |
4 participants
/kind bug
What this PR does / why we need it:
This is backport of #165 into 1.2 branch.
I added extra code to interpret
NotFoundas success (i.e. a volume is considered as detached), so behavior ofNotFounderror handling is not changed in a stable branch./assign @msau42