Skip to content

fix/upgrade CSI side cars to the latest version for k8s 1.13#70

Merged
shay-berman merged 2 commits intodevelopfrom
fix/sidecars-new-versions
Sep 12, 2019
Merged

fix/upgrade CSI side cars to the latest version for k8s 1.13#70
shay-berman merged 2 commits intodevelopfrom
fix/sidecars-new-versions

Conversation

@shay-berman
Copy link
Copy Markdown
Contributor

@shay-berman shay-berman commented Sep 11, 2019

@xyanyang found that that csi side car quay.io/k8scsi/csi-attacher:v1.0.1 is buggy(cause issue with retries), and there is new version v1.2.0 that also compatible with k8s 1.13 and it fix the issue. So this PR fix it.

In addition I reviewed again all the side cars versions, and its good time to update all of them with the latest version that applicable to k8s 1.13.

So this PR upgrade the following side cars:

  • quay.io/k8scsi/csi-attacher:v1.0.1 -> upgraded to the new 1.2.0
  • quay.io/k8scsi/csi-provisioner:v1.1.1 -> upgraded to the new 1.3.0
  • quay.io/k8scsi/csi-node-driver-registrar:v1.0.2 -> upgraded to the new 1.1.0

According to the official CSI page -> https://kubernetes-csi.github.io/docs/sidecar-containers.html

Note: will consider to drop side car container cluster-driver-registrar later on due to deprecation.

  • removing trace log in node identity probe API to reduce nose.

This change is Reviewable

@shay-berman shay-berman added this to the v1.0.0 milestone Sep 11, 2019
@shay-berman shay-berman changed the title use the latest side-car containers version for 1.13 (attacher\registr… fix/upgrade CSI side cars to the latest version for k8s 1.13 Sep 11, 2019
Copy link
Copy Markdown
Contributor

@xyanyang xyanyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

csi-attacher v1.2.0 doesn't work, it has the same problem, we need v1.2.1

Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @ranhrl and @xyanyang)

@shay-berman
Copy link
Copy Markdown
Contributor Author

Hi @xyanyang , it looks like v1.2.1 is not yet GAed.
Added a comment in the PR that related to the v1.2.1 -> kubernetes-csi/external-attacher#168 (comment)

We should follow up, Not sure if we can use v1.2.1 if its not yet GAed.

Copy link
Copy Markdown
Contributor

@ranhrl ranhrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@shay-berman
Copy link
Copy Markdown
Contributor Author

Since attacher 1.2.1 is not GA yet, then we will not use it until we will get confirmation from the community -> kubernetes-csi/external-attacher#168 (comment)

Anyway I am merging now the updated side car containers to develop, and when we will have the approval for v1.2.1 we will change it in later PR.

Merging.

@shay-berman shay-berman merged commit 5029804 into develop Sep 12, 2019
@shay-berman shay-berman deleted the fix/sidecars-new-versions branch September 16, 2019 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants