fix/upgrade CSI side cars to the latest version for k8s 1.13#70
fix/upgrade CSI side cars to the latest version for k8s 1.13#70shay-berman merged 2 commits intodevelopfrom
Conversation
xyanyang
left a comment
There was a problem hiding this comment.
csi-attacher v1.2.0 doesn't work, it has the same problem, we need v1.2.1
Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @ranhrl and @xyanyang)
|
Hi @xyanyang , it looks like v1.2.1 is not yet GAed. We should follow up, Not sure if we can use v1.2.1 if its not yet GAed. |
ranhrl
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
|
Since attacher 1.2.1 is not GA yet, then we will not use it until we will get confirmation from the community -> kubernetes-csi/external-attacher#168 (comment) Anyway I am merging now the updated side car containers to develop, and when we will have the approval for v1.2.1 we will change it in later PR. Merging. |
@xyanyang found that that csi side car
quay.io/k8scsi/csi-attacher:v1.0.1is buggy(cause issue with retries), and there is new version v1.2.0 that also compatible with k8s 1.13 and it fix the issue. So this PR fix it.In addition I reviewed again all the side cars versions, and its good time to update all of them with the latest version that applicable to k8s 1.13.
So this PR upgrade the following side cars:
According to the official CSI page -> https://kubernetes-csi.github.io/docs/sidecar-containers.html
Note: will consider to drop side car container
cluster-driver-registrarlater on due to deprecation.This change is