Skip to content

Conversation

carlbraganza
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake

What this PR does / why we need it:

This PR updates CSI to the v1.10.0 release and adds support for the new SnapshotMetadata service.

Which issue(s) this PR fixes:

Fixes Provide mocks for the SnapshotMetadata service

Special notes for your reviewer:

This PR does the following:

  • It updates the CSI version based on the work done by @huww98 in PR 519
  • It adds a SnapshotMetadata service to the unified driver (CSIDriver) and the CSIDriverController.

Does this PR introduce a user-facing change?:

Added mock interfaces for the `SnapshotMetadata` service introduced in CSI v1.10.0.
Added a `csi.SnapshotMetadataServer` interface to `CSIDriver` and `CSIDriverController`.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 11, 2024
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 11, 2024
@carlbraganza
Copy link
Contributor Author

carlbraganza commented Jul 11, 2024

Steps taken to update to CSI v1.10.0:

  1. Updated github.com/container-storage-interface/spec version in go.mod.
  2. Ran go mod tidy
  3. Ran go mod vendor
  4. Installed mockgen to my PATH with go install github.com/golang/mock/[email protected]
  5. Ran go generate in the driver directory.
  6. Applied the fix from bump CSI spec to v1.10.0 #519 (added csi.Unsafe*** interfaces where necessary in driver and test).

Then I added the SnapshotMetadata interface to the following files in driver:

  • driver-controller.go
  • driver.go
  • mock.go

@jsafrane
Copy link
Contributor

/lgtm
/approve

@jsafrane
Copy link
Contributor

thanks a lot!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 16, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlbraganza, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2024
@k8s-ci-robot k8s-ci-robot merged commit 7a77a22 into kubernetes-csi:master Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide mocks for the SnapshotMetadata service

3 participants