-
Notifications
You must be signed in to change notification settings - Fork 151
bump CSI spec to v1.10.0 #519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: huww98 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @huww98. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
go.mod
Outdated
|
|
||
| require ( | ||
| github.com/container-storage-interface/spec v1.9.0 | ||
| github.com/container-storage-interface/spec v1.9.1-0.20240305034746-abf6346bb13d |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use a released version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this one is the preview of the changes we need, for earlier review and CI.
I will update the PR when the release is ready.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@huww98 The latest commit of the spec on master is now beyond the abf6346bb13d commit - it is at 2696773158b9 and contains the new CBT related SnapshotMetadata service. No official CSI release available yet!
and fix the build failure
|
Updated this PR to use the released version of CSI spec. |
|
I hope I have permission to do this: /ok-to-test |
|
closing because #545 has been merged, which includes this PR. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
bump CSI spec to next version
and fix the build failure
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
This uses an unreleased version of CSI spec. If we are not in hurry merging this, I'll update this PR when a new release is available.
Does this PR introduce a user-facing change?: