Skip to content

master: update release-tools#287

Merged
k8s-ci-robot merged 2 commits intokubernetes-csi:masterfrom
pohly:prow-update-master
May 18, 2021
Merged

master: update release-tools#287
k8s-ci-robot merged 2 commits intokubernetes-csi:masterfrom
pohly:prow-update-master

Conversation

@pohly
Copy link
Copy Markdown
Contributor

@pohly pohly commented May 7, 2021

Squashed 'release-tools/' changes from 6616a6b..09d4151

09d41512 Merge pull request #147 from pohly/mock-testing
74cfbc97 prow.sh: support mock tests
4a3f1103 prow.sh: remove obsolete test suppression

git-subtree-dir: release-tools
git-subtree-split: 09d4151

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 7, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 7, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from msau42 and saad-ali May 7, 2021 07:09
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 7, 2021
@pohly pohly mentioned this pull request May 7, 2021
Merged
@jsafrane
Copy link
Copy Markdown
Contributor

jsafrane commented May 18, 2021

/retest

@pohly
Copy link
Copy Markdown
Contributor Author

pohly commented May 18, 2021

The test-on jobs failed because the necessary PR for those had not been merged ("deploy.sh not found").

@jsafrane
Copy link
Copy Markdown
Contributor

jsafrane commented May 18, 2021

The test-on jobs failed because the necessary PR for those had not been merged ("deploy.sh not found").

How did they succeed in #292?

@pohly
Copy link
Copy Markdown
Contributor Author

pohly commented May 18, 2021

Those jobs ran later.

@pohly
Copy link
Copy Markdown
Contributor Author

pohly commented May 18, 2021

This PR is old 😢

@jsafrane
Copy link
Copy Markdown
Contributor

jsafrane commented May 18, 2021

Ok, now I see the tests are passing. Sorry about the noise.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 18, 2021
@pohly
Copy link
Copy Markdown
Contributor Author

pohly commented May 18, 2021

Ok, now I see the tests are passing. Sorry about the noise.

Not all, I appreciate the diligence. I should have done a retest earlier before bothering you.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 18, 2021 •
edited
Loading

@pohly: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-csi-csi-driver-host-path-1-21-test-on-kubernetes-1-21 56a76c2 link /test pull-kubernetes-csi-csi-driver-host-path-1-21-test-on-kubernetes-1-21

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pohly
Copy link
Copy Markdown
Contributor Author

pohly commented May 18, 2021

/retest

We definitely need PR #293 to avoid these flakes...

@k8s-ci-robot k8s-ci-robot merged commit ac10b91 into kubernetes-csi:master May 18, 2021
@pohly pohly deleted the prow-update-master branch May 19, 2021 14:59
darshansreenivas added a commit to darshansreenivas/csi-driver-host-path that referenced this pull request Jan 11, 2026
@darshansreenivas
Squashed 'release-tools/' changes from 74502e54..b12e407c
e43202f 
b12e407c Merge pull request kubernetes-csi#289 from nixpanic/k8s-v1.34
bbe5e547 Use Kubernetes v1.34 and Kind v0.30 by default
4e9eb2c9 Merge pull request kubernetes-csi#288 from gnufied/add-gnufied-for-csi-approver
064e260d Add myself as csi approver
c852fa79 Merge pull request kubernetes-csi#287 from andyzhangx/patch-7
bce16c10 fix: upgrade to go1.24.11 to fix CVE-2025-61727
8d1258cc Merge pull request kubernetes-csi#286 from kubernetes-csi/dependabot/github_actions/actions/checkout-6
91e35981 Bump actions/checkout from 5 to 6
29413815 Merge pull request kubernetes-csi#285 from andyzhangx/patch-6
fa8b339e fix: upgrade to go1.24.9 to fix CVEs

git-subtree-dir: release-tools
git-subtree-split: b12e407cc9556acf6702ed8745d3f8a29c9169bb
@darshansreenivas darshansreenivas mentioned this pull request Jan 11, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msau42 msau42 Awaiting requested review from msau42

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@jsafrane jsafrane

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pohly @k8s-ci-robot @jsafrane