deploy: replace /var/lib/kubelet on-the-fly#286
deploy: replace /var/lib/kubelet on-the-fly#286k8s-ci-robot merged 1 commit intokubernetes-csi:masterfrom
Conversation
k8s-ci-robot
added
release-note
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pohly The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
| for i in $(ls ${BASE_DIR}/hostpath/*.yaml | sort); do | ||
| echo " $i" | ||
| modified="$(cat "$i" | while IFS= read -r line; do | ||
| modified="$(cat "$i" | sed -e "s;/var/lib/kubelet/;${KUBELET_DATA_DIR:-/var/lib/kubelet}/;" | while IFS= read -r line; do |
There was a problem hiding this comment.
It's probably matter of style, would it be better to have somewhere on the top:
KUBELET_DATA_DIR=${KUBELET_DATA_DIR:-/var/lib/kubelet}
and then use $KUBELET_DATA_DIR without extra expansion, especially when part of a regexp here?
There was a problem hiding this comment.
Yes, that may be a bit more obvious. I'll change it.
This is useful for clusters where kubelet is installed differently. KinD cluster testing might be done with a non-default location to recognize and cleanup loop devices that were set up by the driver.
|
/retest |
|
Longer term, I think it would be easier to maintain customization logic
like this if we move to a templating tool like kustomize
…On Mon, May 10, 2021, 08:42 Jan Šafránek ***@***.***> wrote:
/retest
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#286 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF2QYPISVOVDQ4NDPWPXF23TM75FNANCNFSM44FODKIA>
.
|
I agree, but this is a significant change and some of the things we currently do in shell code (like taking parameters via env variables) will not be straight-forward. So unless we find someone with significant time at his hand I suspect we'll have to stick with what we have. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
@pohly: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest |
b12e407c Merge pull request kubernetes-csi#289 from nixpanic/k8s-v1.34 bbe5e547 Use Kubernetes v1.34 and Kind v0.30 by default 4e9eb2c9 Merge pull request kubernetes-csi#288 from gnufied/add-gnufied-for-csi-approver 064e260d Add myself as csi approver c852fa79 Merge pull request kubernetes-csi#287 from andyzhangx/patch-7 bce16c10 fix: upgrade to go1.24.11 to fix CVE-2025-61727 8d1258cc Merge pull request kubernetes-csi#286 from kubernetes-csi/dependabot/github_actions/actions/checkout-6 91e35981 Bump actions/checkout from 5 to 6 29413815 Merge pull request kubernetes-csi#285 from andyzhangx/patch-6 fa8b339e fix: upgrade to go1.24.9 to fix CVEs git-subtree-dir: release-tools git-subtree-split: b12e407cc9556acf6702ed8745d3f8a29c9169bb
4 participants
What type of PR is this?
/kind feature
What this PR does / why we need it:
This is useful for clusters where kubelet is installed
differently. KinD cluster testing might be done with a non-default
location to recognize and cleanup loop devices that were set up by
the driver.
Which issue(s) this PR fixes:
Fixes #71
Special notes for your reviewer:
Does this PR introduce a user-facing change?: