-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add proxy support to connect to clusters, upgrade gen to OpenAPI 7.1.0 client #2147
base: master
Are you sure you want to change the base?
Add proxy support to connect to clusters, upgrade gen to OpenAPI 7.1.0 client #2147
Conversation
Welcome @rolf-moz! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rolf-moz The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The version is the gen project is actually not honored. This client overrides the value here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good to me. Should we wait for this project to be upgrade to OpenAPI 7.1.0+ first?
@roycaihw |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
@roycaihw I just wanted to follow up as I think this PR is important. Is it good to merge as-is or would you like to split it up between the adding of OpenAPI 7.1.0 support and the actual upgrade? |
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
/remove-lifecycle rotten |
I'm are using ansible k8s to connect to a cluster but we need to be able to connect over socks5, If I understand the stacktrace and the discussion in this PR, this contains the stuff I am looking for. :)
|
@PhroZenOne yes if you want to rebase you can. I might have time later this week too. I'm not up to date... is kubernetes client using 7.x openapi generator yet? If you'd like to try a built library with this support you can use https://github.com/rolf-moz/kubernetes-client-python/tree/feat/add-proxy-support-gen and let me know how it works for you. |
Hm, there are API changes with the newer kubernetes API that breaks when testing so my branch will not work:
I dont have more time to spend on this right now I'm afraid so for now I will give up. I might have more time next month to look at it. |
Made some changes to client.py to make it work again for my use case, but I have no idea if this is a good solution: PhroZenOne@97c36c3 |
@PhroZenOne @roycaihw Ok looks like this branch is getting some use. Let me see if I can update this PR later today to be up to date with main |
What type of PR is this?
/kind feature
This a feature addition to start supporting the 'proxy-url' field in the kubernetes config files.
This will support most proxies. An upcoming version of OpenAPI generator will support Socks proxies as well.
Additionally this PR has changes that the support 7.x OpenAPI generator.
Fixes: #1967
Special notes for your reviewer:
Note this Socks5 support is dependent on a recently merged update I made to OpenAPI generator to support Socks5 proxies: OpenAPITools/openapi-generator#16918 that will be in the upcoming 7.2 release.
For now the python.sh in the gen project (that auto-generates the full client) should be updated to use 7.1.0. Example:
OPENAPI_GENERATOR_COMMIT="${OPENAPI_GENERATOR_COMMIT:-v7.1.0}"
A sample generated project is visible here
https://github.com/rolf-moz/kubernetes-client-python/tree/feat/add-proxy-support-gen
Does this PR introduce a user-facing change?
Yes
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
Proxy support.