Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add socks5 proxy support for OpenAPI generated python client #16918

Merged
merged 7 commits into from
Nov 14, 2023

Conversation

rolf-moz
Copy link
Contributor

@rolf-moz rolf-moz commented Oct 27, 2023

Added support for Socks proxies for python.

This feature was requested: #16568
(note this is a resubmission as my original PR to the 8.x branch was a bad branch)

urlib3 already supports socks with the 'urlib3[socks]' variant or by installing PySocks.
Proxy types mirror what Urlib3 supports: "sock5" "socks5h" "socks4" "socks4a"

I would like advice on how to add tests for this.
@cbornet @tomplus @krjakbrjak @fa0311 @multani

PR checklist

  • [ x] Read the contribution guidelines.
  • [ x] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [x ] Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • [ x] File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • [x ] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@multani
Copy link
Contributor

multani commented Oct 30, 2023

@rolf-moz could you rebase or merge with main?

There has been a large change merged recently that also changed part of the code you want to change.

@rolf-moz
Copy link
Contributor Author

@multani I resolved conflicts with the base branch, and cleaned up the proxy support code a bit.

@wing328 wing328 modified the milestones: 7.1.0, 7.2.0 Nov 13, 2023
@wing328
Copy link
Member

wing328 commented Nov 14, 2023

lgtm. thanks for the PR.

@wing328 wing328 merged commit 2ca9586 into OpenAPITools:master Nov 14, 2023
51 checks passed
jpuerto pushed a commit to movementsciences/openapi-generator that referenced this pull request Nov 14, 2023
…Tools#16918)

* add socks5 proxy support (requires additional import)

* updated examples

* build samples. updated to support pydantic python option

* rename sock to socks for correct protocol name

* add proxy headers for pydantic

* fixed param changes from conflict resolution
lwj5 pushed a commit to lwj5/openapi-generator that referenced this pull request Dec 5, 2023
…Tools#16918)

* add socks5 proxy support (requires additional import)

* updated examples

* build samples. updated to support pydantic python option

* rename sock to socks for correct protocol name

* add proxy headers for pydantic

* fixed param changes from conflict resolution
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants