Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Katib NAS RL algorithm to ENAS #1982

Merged
merged 5 commits into from
Jun 10, 2020

Conversation

andreyvelich
Copy link
Member

@andreyvelich andreyvelich commented Jun 8, 2020

Part of kubeflow/katib#1211.
Ref PR: kubeflow/katib#1143.

I renamed NASRL to ENAS, fixed some links to API docs and added algorithm settings for ENAS.

/assign @jlewi
/cc @gaocegege @johnugeorge

@kubeflow-bot
Copy link

This change is Reviewable

@gaocegege
Copy link
Member

/lgtm

@@ -149,7 +146,7 @@ descriptions on this page:
* [Bayesian optimization](#bayesian)
* [HYPERBAND](#hyperband)
* [Hyperopt TPE](#tpe-search)
* [NAS based on reinforcement learning](#nas)
* [Efficient Neural Architecture Search (ENAS)](#enas)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are not using ENAS, we do not share parameters. Our approach is part of ENAS.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaocegege Should we name it Neural Architecture Search based on ENAS.
What do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM. We can say this algorithm is ENAS-based

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@jlewi
Copy link
Contributor

jlewi commented Jun 9, 2020

/lgtm
/approve
/hold

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the lgtm label Jun 9, 2020
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gaocegege
Copy link
Member

/hold-cancel

@andreyvelich
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit 76a9610 into kubeflow:master Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants