Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change folder structure for NAS algorithms, rename NASRL to ENAS #1143

Merged
merged 7 commits into from
Apr 14, 2020

Conversation

andreyvelich
Copy link
Member

Fixes: #1125.

In this PR:

  1. Create nas/ directory under cmd/suggestion/ directory. Add enas folder there
  2. Create nas/ directory under pkg/suggestion/v1alpha3/ directory. Add enas_service.py and enas there.
  3. Create /examples/v1alpha3/nas/ directory with examples: enas-example-cpu.yaml and enas-example-gpu.yam. And enas training container with docker.io/kubeflowkatib/enas-cnn-cifar10-cpu, docker.io/kubeflowkatib/enas-cnn-cifar10-gpu docker image name. I will push to the appropriate image.
  4. Rename nasrl to enas
  5. Fix all CI test with new folder structure and algorithm name

/assign @gaocegege @johnugeorge @richardsliu

@kubeflow-bot
Copy link

This change is Reviewable

@andreyvelich
Copy link
Member Author

/retest

@johnugeorge
Copy link
Member

/lgtm

@johnugeorge
Copy link
Member

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the lgtm label Apr 14, 2020
@johnugeorge
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit ad7dc28 into kubeflow:master Apr 14, 2020
sperlingxx pushed a commit to sperlingxx/katib that referenced this pull request Jul 9, 2020
…eflow#1143)

* Init commit

* Rename nasrl to enas

* Modify docker ignore

* Undo changes for nas monitor js

* Fix enas cnn docker image name

* Rename ENAS in README
@andreyvelich andreyvelich deleted the rename-nasrl-to-enas branch October 6, 2021 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Structure for NAS algorithms
6 participants