Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Added @rimolive, @hbelmiro and @DharmitD as approvers and reviewers for GitHub Actions #10963

Merged
merged 1 commit into from
Jun 29, 2024

Conversation

@hbelmiro
Copy link
Contributor Author

.github/OWNERS Outdated
- zijianjoy
- rimolive
- hbelmiro
- DharmitD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: Fix EoF

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

scripts/OWNERS Outdated
- zijianjoy
- rimolive
- hbelmiro
- DharmitD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: Fix EoF

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Copy link
Contributor

@DharmitD DharmitD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nitpick but otherwise,
/lgtm

@hbelmiro thank you for making this PR on our behalf! :)

@google-oss-prow google-oss-prow bot added lgtm and removed lgtm labels Jun 26, 2024
@hbelmiro hbelmiro force-pushed the gha-approvers branch 2 times, most recently from 9dd4195 to 3383ba6 Compare June 26, 2024 18:40
@hbelmiro hbelmiro changed the title chore: Added @rimolive, @hbelmiro and @DharmitD as approvers for GitHub Actions chore: Added @rimolive, @gregsheremeta, @hbelmiro and @DharmitD as approvers and reviewers for GitHub Actions Jun 26, 2024
…ewers for GitHub Actions.

Signed-off-by: hbelmiro <[email protected]>
@hbelmiro hbelmiro changed the title chore: Added @rimolive, @gregsheremeta, @hbelmiro and @DharmitD as approvers and reviewers for GitHub Actions chore: Added @rimolive, @hbelmiro and @DharmitD as approvers and reviewers for GitHub Actions Jun 26, 2024
@rimolive
Copy link
Member

/lgtm

cc @chensun @zijianjoy @james-jwu

Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thank you all for your contribution on migration the tests!

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit fb9213b into kubeflow:master Jun 29, 2024
3 checks passed
@hbelmiro hbelmiro deleted the gha-approvers branch June 29, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants