Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Created a new GitHub action to reuse the creation of a KFP cluster #10946

Merged
merged 2 commits into from
Jun 29, 2024

Conversation

hbelmiro
Copy link
Contributor

Description of your changes:
This PR adds a new GitHub action to be reused by test workflows. This is intended to avoid code duplication across multiple workflows.

Checklist:

Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@hbelmiro
Copy link
Contributor Author

cc @chensun

Copy link
Contributor

@DharmitD DharmitD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rimolive
Copy link
Member

/approve

@rimolive
Copy link
Member

cc @james-jwu

@hbelmiro
Copy link
Contributor Author

cc @chensun @zijianjoy @james-jwu


- name: Deploy KFP
shell: bash
run: ./scripts/deploy/github/deploy-kfp.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hbelmiro looks like this script deploys just kfp-tekton and not pipelines. @rimolive could you confirm?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@DharmitD
Copy link
Contributor

/hold

Copy link
Contributor

@DharmitD DharmitD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

cc: @rimolive @chensun

@google-oss-prow google-oss-prow bot added the lgtm label Jun 28, 2024
@hbelmiro
Copy link
Contributor Author

/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hbelmiro, rimolive

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hbelmiro
Copy link
Contributor Author

/unhold

@google-oss-prow google-oss-prow bot merged commit 7a21329 into kubeflow:master Jun 29, 2024
5 checks passed
@hbelmiro hbelmiro deleted the action-for-kfp-cluster branch June 29, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants