Skip to content

Conversation

@yehudit1987
Copy link

@yehudit1987 yehudit1987 commented Oct 30, 2025

…Components

  • Delete common component (OWNERS, go.mod, reconcilehelper/)
  • Copy reconcilehelper/util.go to both notebook-controller and tensorboard-controller
  • Update imports in both controllers to use local reconcilehelper
  • Remove common dependency from go.mod files
  • Update Dockerfiles to remove common component references

Fix issue: #700

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign thesuperzapper for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot added area/v1 area - version - kubeflow notebooks v1 size/L labels Oct 30, 2025
…Components

- Delete common component (OWNERS, go.mod, reconcilehelper/)
- Copy reconcilehelper/util.go to both notebook-controller and tensorboard-controller
- Update imports in both controllers to use local reconcilehelper
- Remove common dependency from go.mod files
- Update Dockerfiles to remove common component references

Signed-off-by: Yehudit Kerido <[email protected]>
@yehudit1987 yehudit1987 force-pushed the remove_common_component branch 2 times, most recently from 9693766 to e88a97e Compare October 30, 2025 14:27
@yehudit1987 yehudit1987 marked this pull request as ready for review October 30, 2025 14:52
@andyatmiami
Copy link
Contributor

/ok-to-test

@andyatmiami
Copy link
Contributor

/lgtm

confirmed the reconcilehelper util.go file that has been duplicated in NBC and TBC exactly matches the original common util.go

MD5 (/tmp/original_util.go) = 338cebd04529f59feae5f02bc7997e23
MD5 (components/notebook-controller/reconcilehelper/util.go) = 338cebd04529f59feae5f02bc7997e23
MD5 (components/tensorboard-controller/reconcilehelper/util.go) = 338cebd04529f59feae5f02bc7997e23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/controller area - related to controller components area/v1 area - version - kubeflow notebooks v1 lgtm ok-to-test size/L

Projects

Status: Needs Triage

Development

Successfully merging this pull request may close these issues.

2 participants