[TASK] Remove Common Component and Copy Shared Code into Relevant Components

[liavweiss]

Certification

• I certify I am an Epic Owner for Kubeflow Notebooks 2.0 and expected to create planning-related issues.

Description

Description:
The common component should be removed. Based on #584 (comment) shared functionality, specifically the reconcile/ logic, must be copied into the individual controllers that consume it (notebook-controller and tensorboard-controller).

Implementation:

• Delete any require entries referencing to github.com/kubeflow/kubeflow/components/common from go.mod
  For example:

  notebooks/components/notebook-controller/go.mod

  Line 7 in e4c3bc1

  github.com/kubeflow/kubeflow/components/common v0.0.0-20220218084159-4ad0158e955e

  .

• Remove common/ component from the code

• Copy the reconcilehelper/ directory from the old common module into tensorboard-controller and notebook-controller

• Replace/Remove common/ path in workflows/ actions to be correct
  For example:
  https://github.com/kubeflow/notebooks/pull/622/files

**This work will depend on some _docker_publish.yaml PRs to be merged first.

Acceptance Criteria

• Delete any require entries referencing to github.com/kubeflow/kubeflow/components/common from go.mod
• The common component is fully removed from the repository.
• Both notebook-controller and tensorboard-controller include their own copies of the reconcilehelper code.
• All imports are correctly updated or removed.
• Builds and tests pass for all components.
• all related workflow passes

[liavweiss]

/area v1

[yehudit1987]

/assign

[liavweiss]

/close

[google-oss-prow]

@liavweiss: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.