Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom metrics collector kind #908

Merged
merged 2 commits into from
Nov 4, 2019
Merged

Support custom metrics collector kind #908

merged 2 commits into from
Nov 4, 2019

Conversation

hougangliu
Copy link
Member

@hougangliu hougangliu commented Nov 1, 2019

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:



This change is Reviewable

@hougangliu
Copy link
Member Author

/cc @gaocegege @johnugeorge

@hougangliu
Copy link
Member Author

/test kubeflow-katib-presubmit

2 similar comments
@hougangliu
Copy link
Member Author

/test kubeflow-katib-presubmit

@hougangliu
Copy link
Member Author

/test kubeflow-katib-presubmit

@hougangliu
Copy link
Member Author

/test kubeflow-katib-presubmit

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hougangliu
Copy link
Member Author

/test kubeflow-katib-presubmit

@k8s-ci-robot k8s-ci-robot merged commit 2df906e into kubeflow:master Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants