Katib v1beta1 version #1197
Katib v1beta1 version #1197
Conversation
Fix format in bash scripts
|
This change is |
|
/retest |
|
/retest |
|
@johnugeorge @gaocegege I disabled e2e test for custom metrics collector in v1beta1. Currently, in this metrics collector we report metrics using I added comment to e2e test and yaml file for the custom metrics collector. |
|
/retest |
1 similar comment
|
/retest |
|
/lgtm I think we can merge it and fix problems in other PRs if there is any. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Add v1beta1 version * Swagger for v1alpha3 and v1beta1 versions Fix format in bash scripts * Change make build to make buildv1alpha3 * Add folder path to python test * Fix folder in python test * Add goptuna and darts suggestions to check-katib-ready * Disable custom metrics collector e2e in v1beta1
I added v1beta1 version to continue Katib development and adding new API changes.
See discussion: #1186.
All API and Controller logics are the same as in v1alpha3 .
I didn't make doc changes in this PR, only for https://github.com/andreyvelich/katib/blob/v1beta1-version/docs/developer-guide.md, because I changed Makefile. For other doc we can make changes in the separate PR, since it will affect Kubeflow website.
For Makefile I changed corresponding scripts (deploy, undeploy, ..) to new v1beta1 version. Old scripts I renamed to
<script-name>v1alpha3accordingly.For Swagger I created API for v1alpha3 and v1beta1 versions. @sperlingxx Do we need to make v0.1 Swagger version for every Katib version (https://github.com/andreyvelich/katib/blob/v1beta1-version/hack/swagger/main.go#L65) ? If not, I can rename it to appropriate Katib version.
/assign @johnugeorge @gaocegege