Test for Bayesian Optimization Algo

[jdplatt]

#230

Here is a PR containing tests for the code in pkg/suggestion/bayesianoptimization. You can run them using test/scripts/python_tests.sh. I have close to full coverage but didn't cover the parts of the code that deal with the beginning of tuning when there is no data. I think there is a cleaner way to handle this using a different suggestion algorithm such as random search. I fixed a few bugs in the way the models were trained alongside writing the tests.

---

This change is 

[k8s-ci-robot]

Hi @jdplatt. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[YujiOshima]

@jdplatt Thank you for PR! Could you sign the CLA?

[jdplatt]

I signed it!

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[jdplatt]

@YujiOshima

Had a few issues getting corporate CLA to work but should be all good now.

[YujiOshima]

Thanks, I will take a look!

[jdplatt]

Thanks for looking at my PR. I fixed the two issues you raised. Do you need me to do anything else?

[YujiOshima]

@jdplatt Thanks!
/ok-to-test

[richardsliu]

General comment (for all test files):
For all the tests, add a brief comment section that explains what this test does, what are the expectations, etc. This makes it easier for other contributors to follow.

[richardsliu]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardsliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [richardsliu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment