Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Add test code for each algorithms #42

Closed
YujiOshima opened this issue Apr 13, 2018 · 16 comments
Closed

[feature] Add test code for each algorithms #42

YujiOshima opened this issue Apr 13, 2018 · 16 comments

Comments

@YujiOshima
Copy link
Contributor

There is no test code for each suggestion and early stop algorithms.
We need to test the algorithms will work as expected.

@lluunn
Copy link
Contributor

lluunn commented Jun 19, 2018

Does it mean adding unit test, like grid_service_test.go, in https://github.com/kubeflow/katib/tree/master/pkg/suggestion?

@jlewi
Copy link
Contributor

jlewi commented Oct 8, 2018

/area 0.4.0

@jlewi
Copy link
Contributor

jlewi commented Oct 9, 2018

Should we split this issue up into multiple issues?

@garganubhav
Copy link
Contributor

@jlewi @YujiOshima is someone already doing this, or I should start working on this?

@YujiOshima
Copy link
Contributor Author

@garganubhav Thanks. My colleague is working on random, grid, and hyperband.
I'm so happy if you try to add tests to the Bayesian opt algorithm,

@jlewi
Copy link
Contributor

jlewi commented Oct 29, 2018

@garganubhav @YujiOshima per my comment above can we file individual issues for adding tests for specific algorithms and assign them to individual owners?

@garganubhav
Copy link
Contributor

@jlewi ok. I will file for Bayesian opt algorithm and work on it.

@jlewi
Copy link
Contributor

jlewi commented Nov 26, 2018

@garganubhav any progress? Did you open up an issue for Bayesian optimization?

@garganubhav
Copy link
Contributor

yes, working on it

@jlewi
Copy link
Contributor

jlewi commented Dec 17, 2018

@garganubhav Any update on this? What is the remaining work? Do we have an estimate for when it will be completed? Should we move this issue to 0.5 at this point?

@jlewi
Copy link
Contributor

jlewi commented Jan 7, 2019

@garganubhav @johnugeorge @YujiOshima @gaocegege

What's the current status of this issue?

It looks like there is #230 for a test for bayesian optimization. Can we close out this issue since that issue exists?

/cc @richardsliu

@jlewi
Copy link
Contributor

jlewi commented Feb 11, 2019

@gaocegege
Copy link
Member

We do not have sufficient test coverage for algos, IMO. And it is hard to import tools to show the coverage since we allow different languages to write suggestions.

@jdplatt
Copy link
Contributor

jdplatt commented Mar 17, 2019

Can we close this now #406 is merged? What is the status of the e2e tests of the algorithms that use https://github.com/kubeflow/katib/blob/master/test/e2e/test-client.go.

@johnugeorge
Copy link
Member

Closing this as #406 is merged. Moving algorithms to Python is tracked in #407

/close

@k8s-ci-robot
Copy link

@johnugeorge: Closing this issue.

In response to this:

Closing this as #406 is merged. Moving algorithms to Python is tracked in #407

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants