Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KTOR-8064 Add media type for Yaml #4600

Merged
merged 4 commits into from
Jan 14, 2025
Merged

KTOR-8064 Add media type for Yaml #4600

merged 4 commits into from
Jan 14, 2025

Conversation

IRus
Copy link
Contributor

@IRus IRus commented Jan 13, 2025

Copy link
Member

@osipxd osipxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! Thank you for your contribution!

Could you check if "Allow edits from maintainers" is enabled for this PR? We need this permission to rebase the PR before merging.

@osipxd osipxd enabled auto-merge (squash) January 14, 2025 09:58
@IRus
Copy link
Contributor Author

IRus commented Jan 14, 2025

@osipxd Thank you.

I forked repository as organization, and I can't find "Allow edits from maintainers" setting for this MR:
Screenshot 2025-01-14 at 15 01 40

I rebased it tho, and can rebase later as well.

@osipxd
Copy link
Member

osipxd commented Jan 14, 2025

@IRus, could you rebase your PR one more time, please? I'm going to merge it next.

@IRus
Copy link
Contributor Author

IRus commented Jan 14, 2025

@osipxd done

@osipxd osipxd merged commit 9535a8e into ktorio:main Jan 14, 2025
13 of 15 checks passed
@IRus
Copy link
Contributor Author

IRus commented Jan 14, 2025

@osipxd thanks for quick turnaround

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants