KTOR-7327 Support conversion between byte channel interfaces and kotlinx-io primitives #4594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeWharton
reviewed
Jan 10, 2025
e5l
commented
Jan 10, 2025
There was a problem hiding this comment.
Hey @JakeWharton, thanks for the review! I'll check on the comments
osipxd
approved these changes
Jan 14, 2025
osipxd
reviewed
Jan 14, 2025
|
Disabled auto-merge because I want to merge #4600 first. Not to force a contributor to rebase his PR one more time. |
Co-authored-by: Jake Wharton <[email protected]>
Co-authored-by: Jake Wharton <[email protected]>
osipxd
force-pushed
the
e5l/streams-bc
branch
from
89a5872 to
9131d12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix KTOR-7327 Support conversion between byte channel interfaces and kotlinx-io primitives