chore(design-tokens): replace last batch legacy tokens #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hebernardEquisoft
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
Storybook for this build: https://ds.equisoft.io/pr-851/ |
meriouma
reviewed
Apr 24, 2024
| @@ -54,7 +54,7 @@ export type DatepickerTokenMap = { | |||
|
|
|||
| export const defaultDatepickerTokens: DatepickerTokenMap = { | |||
| 'datepicker-border-color': 'color-neutral-15', | |||
| 'datepicker-box-shadow-color': 'transparent-20', | |||
| 'datepicker-box-shadow-color': 'transparent-dark-20', | |||
There was a problem hiding this comment.
J'avais raté ça, mais on dirait que c'est bizarre. C'est transparent ou ce l'est pas. Ça devrait être sur une autre échelle de couleurs, parce que le rgb se modifie pas de toute façon. Le dark est toujours 0/0/0 et le light 255/255/255. Ça semble plus être un grayscale que de la transparence.
There was a problem hiding this comment.
Ouin c'est une solution temporaire pour la question de transparence!
Dans les tokens configurables on vient justement donner la possibilité d'ajouter de la transparence sur la couleur souhaité... Mais à rediscuter.
1 task
hebernardEquisoft
temporarily deployed
to
github-pages
GitHub Actions
Inactive
pylafleur
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DS-1122
Description
Ici on vient replacer les dernières utilisations de
LegacyTokens. Les changements contenu dans cette PR sont en collaboration avec @maboilard.Tests fonctionnels