feat(table,storybook): add header grouping to table header #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmorin-equisoft
force-pushed
the
dev/DS-933
branch
2 times, most recently
from
653bcc6
to
01ff72b
Compare
mmorin-equisoft
changed the title
mmorin-equisoft
force-pushed
the
dev/DS-933
branch
from
01ff72b
to
426ac0f
Compare
mmorin-equisoft
changed the title
mmorin-equisoft
force-pushed
the
dev/DS-933
branch
from
426ac0f
to
4b66573
Compare
mmorin-equisoft
commented
Mar 25, 2024
mmorin-equisoft
temporarily deployed
to
github-pages
GitHub Actions
Inactive
mmorin-equisoft
force-pushed
the
dev/DS-933
branch
from
4b66573
to
ff0782a
Compare
|
Storybook for this build: https://ds.equisoft.io/pr-784/ |
mmorin-equisoft
temporarily deployed
to
github-pages
GitHub Actions
Inactive
mmorin-equisoft
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
C'est un cas particulier ici car on a pas de Figma ni de Notion par rapport a ca (c'est bizarre sans les lignes verticales). J'imagine on veut demontrer que c'est un truc fesable mais ce n'est pas encore officiellement supporte/documente. Pour moi c'est good. |
savutsang
previously approved these changes
Mar 26, 2024
alexbrillant
previously approved these changes
Apr 1, 2024
mmorin-equisoft
temporarily deployed
to
github-pages
GitHub Actions
Inactive
maboilard
requested changes
Apr 15, 2024
There was a problem hiding this comment.
J'ajouterais un séparateur entre les groupes de premier niveau (voir exemple ici) afin de bien délimiter l'information lorsqu'il y a des éléments alignés à droite.
J'ai aussi remarqué que la hauter du column header n'est pas la même que les rows mais ça semble être le cas un peu partout. Je vais donc créer un autre ticket pour régler ce bug.
À part ça, c'est all good pour moi! :)
mmorin-equisoft
dismissed stale reviews from alexbrillant and savutsang
via
482028d
mmorin-equisoft
force-pushed
the
dev/DS-933
branch
2 times, most recently
from
317f66c
to
25fc4b9
Compare
mmorin-equisoft
temporarily deployed
to
github-pages
GitHub Actions
Inactive
mmorin-equisoft
force-pushed
the
dev/DS-933
branch
2 times, most recently
from
1d53331
to
0a3cbf8
Compare
mmorin-equisoft
temporarily deployed
to
github-pages
GitHub Actions
Inactive
mmorin-equisoft
commented
Apr 17, 2024
| ${({ hasRightBorder }) => hasRightBorder && css` | ||
| border-right: 1px solid ${({ theme }) => theme.greys.grey}; | ||
| `} | ||
|
|
||
| &:before { | ||
| border-bottom: 1px solid ${({ theme }) => theme.greys.grey}; |
There was a problem hiding this comment.
Je viens de me rendre compte qu'on pas fait la migration vers les design tokens. Est-ce que c'est volontaire?
There was a problem hiding this comment.
Henri s'en occupe dans #851
mmorin-equisoft
force-pushed
the
dev/DS-933
branch
3 times, most recently
from
32e81c6
to
6d0ad4c
Compare
mmorin-equisoft
temporarily deployed
to
github-pages
GitHub Actions
Inactive
meriouma
reviewed
Apr 25, 2024
| ${({ hasRightBorder }) => hasRightBorder && css` | ||
| border-right: 1px solid ${({ theme }) => theme.greys.grey}; | ||
| `} | ||
|
|
||
| &:before { | ||
| border-bottom: 1px solid ${({ theme }) => theme.greys.grey}; |
There was a problem hiding this comment.
Henri s'en occupe dans #851
mmorin-equisoft
force-pushed
the
dev/DS-933
branch
2 times, most recently
from
3ad9723
to
852d87d
Compare
mmorin-equisoft
force-pushed
the
dev/DS-933
branch
from
852d87d
to
91918d7
Compare
mmorin-equisoft
temporarily deployed
to
github-pages
GitHub Actions
Inactive
1 task
meriouma
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://equisoft.atlassian.net/browse/DS-933