Skip to content

test: revive super circuit unit test#21

Merged
chokobole merged 3 commits into
kroma-v0.3.0-cherrypickfrom
test/revive-super-circuit-unit-test
Jul 13, 2023
Merged

test: revive super circuit unit test#21
chokobole merged 3 commits into
kroma-v0.3.0-cherrypickfrom
test/revive-super-circuit-unit-test

Conversation

@fakedev9999

Copy link
Copy Markdown

Changes

  • fix constant configs for super circuit unit tests so that super circuit unit tests work
  • add description for the bytecode table which I got to know while debugging super circuit unit tests
  • align naming which wasn't properly managed in the past change

@fakedev9999 fakedev9999 requested a review from a team July 11, 2023 08:47
Comment thread zkevm-circuits/src/super_circuit.rs Outdated
@fakedev9999 fakedev9999 force-pushed the test/revive-super-circuit-unit-test branch from 4f00907 to ed8df7d Compare July 11, 2023 09:25
@chokobole

Copy link
Copy Markdown
Contributor

Please update the commit

  • docs: add description for bytecode table -> docs(zkevm-circuits): add description for bytecode table
  • refac: align naming according to past changes -> refac(zkevm-circuits): align naming according to past changes

@chokobole

Copy link
Copy Markdown
Contributor

Could you attach the link "privacy-ethereum/zkevm-circuits#1044" in the commit for easy navigation?

@dongchangYoo dongchangYoo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fakedev9999 fakedev9999 force-pushed the test/revive-super-circuit-unit-test branch 4 times, most recently from 2202da2 to 7d5b4e9 Compare July 12, 2023 10:59
@fakedev9999

Copy link
Copy Markdown
Author

Please update the commit

  • docs: add description for bytecode table -> docs(zkevm-circuits): add description for bytecode table
  • refac: align naming according to past changes -> refac(zkevm-circuits): align naming according to past changes

Applied.

Could you attach the link "privacy-scaling-explorations/zkevm-circuits#1044" in the commit for easy navigation?

Applied.

TomTaehoonKim added 3 commits July 12, 2023 20:53
* Set proper values for circuit parameters

* Fix not to sign deposit transactions
* In PR from PSE,
  github.com/privacy-ethereum/zkevm-circuits/pull/1044
  there was a renaming from Length to Header of the Bytecode Tag.
  However, some parts of the code were not properly updated, so
  I made the change.
@fakedev9999 fakedev9999 force-pushed the test/revive-super-circuit-unit-test branch from 7d5b4e9 to 7fe8d0b Compare July 12, 2023 11:54

@lightscale-luke lightscale-luke left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chokobole chokobole left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chokobole chokobole merged commit 2476f67 into kroma-v0.3.0-cherrypick Jul 13, 2023
@chokobole chokobole deleted the test/revive-super-circuit-unit-test branch July 13, 2023 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants