This repository was archived by the owner on Jul 5, 2024. It is now read-only.
Implement bytecode refactor spec in circuit#1044
Merged
Merged
Conversation
github-actions
Bot
added
the
crate-zkevm-circuits
leolara
changed the title
github-actions
Bot
added
crate-circuit-benchmarks
han0110
approved these changes
Jan 17, 2023
han0110
left a comment
han0110
left a comment
Contributor
There was a problem hiding this comment.
LGMT! Nice refactor! Only left some unimportant comments.
Co-authored-by: Han <tinghan0110@gmail.com>
Contributor
Author
|
please @icemelon assign a reviewer |
Collaborator
|
I assigned myself and will take a look this week. @leolara |
ChihChengLiang
approved these changes
Jan 30, 2023
ChihChengLiang
left a comment
ChihChengLiang
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. I left some comments, but they might be out of the scope of this PR. Feel free to ignore them.
| cb.require_equal( | ||
| "assert cur.hash == EMPTY_HASH", | ||
| meta.query_advice(bytecode_table.code_hash, Rotation::cur()), | ||
| empty_hash, |
Collaborator
There was a problem hiding this comment.
I remember we have cb.empty_hash_rlc(), but that method was available for ConstraintBuilder but not for BaseConstraintBuilder.
No change is needed here.
| meta.query_advice(keccak_table.is_enabled, Rotation::cur()), | ||
| )]; | ||
|
|
||
| // TODO: perhaps write this explicitly so it is more readable the matching |
Collaborator
There was a problem hiding this comment.
Agree we should make this more readable. One idea I have in mind is to have a function in keccak table side.
match_columns(input_rlc, length, output_hash) -> Vec<(Column, Column)>
The function is only responsible for yielding correct pairs of columns. We then add selectors and query cells here.
Contributor
Author
There was a problem hiding this comment.
I was going to complain, but I actually think what you are saying makes sense.
Co-authored-by: Chih Cheng Liang <chihchengliang@gmail.com>
fakedev9999
pushed a commit
to kroma-network/zkevm-circuits
that referenced
this pull request
Jul 12, 2023
* In [#1044](privacy-ethereum/zkevm-circuits#1044) PR from PSE, there was a renaming from Length to Header of the Bytecode Tag. However, some parts of the code were not properly updated, so I made the change.
fakedev9999
pushed a commit
to kroma-network/zkevm-circuits
that referenced
this pull request
Jul 12, 2023
* In PR from PSE, github.com/privacy-ethereum/zkevm-circuits/pull/1044 there was a renaming from Length to Header of the Bytecode Tag. However, some parts of the code were not properly updated, so I made the change.
fakedev9999
pushed a commit
to kroma-network/zkevm-circuits
that referenced
this pull request
Jul 12, 2023
* In PR from PSE, github.com/privacy-ethereum/zkevm-circuits/pull/1044 there was a renaming from Length to Header of the Bytecode Tag. However, some parts of the code were not properly updated, so I made the change.
lightscale-luke
pushed a commit
to kroma-network/zkevm-circuits
that referenced
this pull request
Jul 17, 2023
* In PR from PSE, github.com/privacy-ethereum/zkevm-circuits/pull/1044 there was a renaming from Length to Header of the Bytecode Tag. However, some parts of the code were not properly updated, so I made the change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1026
We have done the following refactor to the spec:
privacy-ethereum/zkevm-specs#151
privacy-ethereum/zkevm-specs#340
privacy-ethereum/zkevm-specs#351
This task is to implement this new spec into the bytecode circuit implementation in this repo.