Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConvertHistoryViewModelTest #439

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

kosenda
Copy link
Owner

@kosenda kosenda commented Jan 11, 2024

元PR

Overview

  • 不要なテストとか消した
  • onceとか条件ではないもの消した(できれば 対象_条件_期待値にしたい)

@roborazzi-compare
Copy link

File name Image
ui_PreviewTopBar-Dark-0_compare.png
ui_PreviewTopBar-Light-0_compare.png
ui_PreviewDragHandler-Dark-2_compare.png
ui_PreviewDragHandler-Light-2_compare.png
ui_PreviewInfoScreenContent-Dark-0_compare.png
ui_PreviewInfoScreenContent-Light-0_compare.png
ui_PreviewPrivacyPolicyContent-Dark-1_compare.png
ui_PreviewPrivacyPolicyContent-Light-1_compare.png
ui_PreviewToTopFloatingPlayer-Dark-3_compare.png
ui_PreviewToTopFloatingPlayer-Light-3_compare.png
ui_PreviewSelectLanguageDialogContent-Dark-0_compare.png
ui_PreviewSelectLanguageDialogContent-Light-0_compare.png
ui_PreviewSettingScreenContent-Dark-1_compare.png
ui_PreviewSettingScreenContent-Light-1_compare.png
ui_PreviewConvertHistoryDetailDialogContent-Dark-0_compare.png
ui_PreviewConvertHistoryDetailDialogContent-Light-0_compare.png
ui_PreviewConvertHistoryScreeContent-Dark-1_compare.png
ui_PreviewConvertHistoryScreeContent-Light-1_compare.png
ui_PreviewConvertHistoryScreenContent_NoData-Dark-2_compare.png
ui_PreviewConvertHistoryScreenContent_NoData-Light-2_compare.png
ui_PreviewConvertButton-Dark_compare.png
ui_PreviewConvertButton-Light_compare.png
ui_PreviewCustomButtonWithBackground-Dark_compare.png
ui_PreviewCustomButtonWithBackground-Light_compare.png
ui_PreviewCustomIconButton-Dark_compare.png
ui_PreviewCustomIconButton-Light_compare.png
ui_PreviewCustomThemeRadioButton-Dark_compare.png
ui_PreviewCustomThemeRadioButton-Light_compare.png
ui_PreviewDeleteButton-Dark_compare.png
ui_PreviewDeleteButton-Light_compare.png
ui_PreviewMoveTopButton_-Dark_compare.png
ui_PreviewMoveTopButton_-Light_compare.png
ui_PreviewTransitionButton-Dark_compare.png
ui_PreviewTransitionButton-Light_compare.png
ui_PreviewConversionTypeCard-Dark_compare.png
ui_PreviewConversionTypeCard-Light_compare.png
ui_PreviewConvertHistoryCard-Dark_compare.png
ui_PreviewConvertHistoryCard-Light_compare.png
ui_PreviewErrorCard-Dark_compare.png
ui_PreviewErrorCard-Light_compare.png
ui_PreviewLanguageCard-Dark_compare.png
ui_PreviewLanguageCard-Light_compare.png
ui_PreviewOfflineCard-Dark_compare.png
ui_PreviewOfflineCard-Light_compare.png
ui_PreviewTitleCard-Dark_compare.png
ui_PreviewTitleCard-Light_compare.png
ui_PreviewBackTopBar-Dark_compare.png
ui_PreviewBackTopBar-Light_compare.png
ui_PreviewConverterScreenContent-Dark-0_compare.png
ui_PreviewConverterScreenContent-Light-0_compare.png
converterScreen_dark_compare.png
converterScreen_light_compare.png

@KSNDBOT
Copy link
Collaborator

KSNDBOT commented Jan 11, 2024

JaCoCo Code Coverage 77.02% ✅

Class Covered Meta Status

Generated by 🚫 Danger

@kosenda kosenda merged commit 7033b3c into refactor/test Jan 11, 2024
4 checks passed
@kosenda kosenda deleted the refactor/convert-history-viewmodel-test branch January 11, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants