Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[リファクタ] テスト全般 #438

Merged
merged 12 commits into from
Jan 13, 2024
Merged

[リファクタ] テスト全般 #438

merged 12 commits into from
Jan 13, 2024

Conversation

kosenda
Copy link
Owner

@kosenda kosenda commented Jan 11, 2024 •
edited
Loading

Issue

Overview

  • テストのリファクタを全体的に行うにあたってCIのスクリーンショットテストはしないようにする（S3無料枠なんか超えそう...）
  • 修正したテストはこのPRにマージして、ある程度修正できたらスクショできるように戻してdevelopにマージする
  • 修正した時のテスト全般に関わる知識とかはissueにまとめてく

@KSNDBOT
Copy link
Collaborator

KSNDBOT commented Jan 11, 2024 •
edited
Loading

JaCoCo Code Coverage 76.92% ✅

Class Covered Meta Status

Generated by 🚫 Danger

@kosenda kosenda mentioned this pull request Jan 11, 2024
Merged
@kosenda kosenda changed the title リファクタテスト [リファクタ] テスト全般 Jan 11, 2024
@kosenda kosenda mentioned this pull request Jan 11, 2024
Merged
@kosenda kosenda mentioned this pull request Jan 13, 2024
Merged
@kosenda kosenda mentioned this pull request Jan 13, 2024
Merged
@kosenda kosenda mentioned this pull request Jan 13, 2024
Merged
@kosenda
Merge pull request #443 from kosenda/refactor/app-module-test
d4466a3 
[リファクタ] :app のテスト全般
@kosenda kosenda marked this pull request as ready for review January 13, 2024 07:57
@kosenda
Copy link
Owner Author

kosenda commented Jan 13, 2024

一旦リファクタ全体的にできたかと思うからマージしてしまう

@kosenda kosenda merged commit e6079e1 into develop Jan 13, 2024
3 checks passed
@kosenda kosenda deleted the refactor/test branch January 13, 2024 08:07
@kosenda kosenda mentioned this pull request Jan 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[リファクタ]　テストの書き方をできるだけ見やすくする
2 participants
@kosenda @KSNDBOT