improve image tensor conversions #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgarriba
commented
Sep 28, 2024
| /// | ||
| /// Returns a `TensorAllocatorError` if the allocation fails. | ||
| pub fn from_slice(data: &[T], alloc: A) -> Self { | ||
| let buffer = Buffer::from_slice_ref(data); |
There was a problem hiding this comment.
@emilmgeorge discovered this function, i thinks it still makes copy but we can explore later more safer ways to achieve zero copies. Another alternative could be to explore from_bytes https://docs.rs/arrow-buffer/latest/arrow_buffer/buffer/struct.Buffer.html#method.from_bytes
There was a problem hiding this comment.
👍🏼 (also: need to check how to handle custom allocations for non-CPU allocators?).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buffer::from_slice_refin TensorStorage creationfrom_size_sliceinImageTryFromfor Image/Tensor conversion