Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert buildSrc to using kts #1830

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Convert buildSrc to using kts #1830

merged 2 commits into from
Aug 9, 2023

Conversation

Kietyo
Copy link
Contributor

@Kietyo Kietyo commented Aug 9, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2023

Codecov Report

Patch coverage: 31.57% and project coverage change: -0.40% ⚠️

Comparison is base (56e9a4a) 51.48% compared to head (8c96463) 51.09%.
Report is 4 commits behind head on main.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1830      +/-   ##
==========================================
- Coverage   51.48%   51.09%   -0.40%     
==========================================
  Files        1750     1749       -1     
  Lines      102826   102833       +7     
  Branches    14519    14519              
==========================================
- Hits        52944    52541     -403     
- Misses      45913    46343     +430     
+ Partials     3969     3949      -20     
Flag Coverage Δ
unittests 51.09% <31.57%> (-0.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...libs/korge/gradle/targets/desktop/DesktopCommon.kt 0.00% <0.00%> (ø)
buildSrc/src/main/kotlin/korlibs/tools.kt 0.00% <0.00%> (ø)
...Main/kotlin/korlibs/render/DefaultGameWindowJvm.kt 0.00% <ø> (ø)
...in/kotlin/korlibs/render/platform/PlatformTools.kt 0.00% <ø> (ø)
...Main/kotlin/korlibs/render/x11/X11GameWindowJvm.kt 0.00% <0.00%> (ø)
...Main/kotlin/korlibs/korge/testing/testing_utils.kt 7.61% <66.66%> (-9.86%) ⬇️
...dMain/kotlin/korlibs/inject/AsyncInjectorJvmExt.kt 39.28% <100.00%> (-0.37%) ⬇️
...rc/commonTest/kotlin/korlibs/io/vfs/VfsFileTest.kt 87.07% <100.00%> (ø)

... and 54 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kietyo Kietyo merged commit 1887888 into korlibs:main Aug 9, 2023
9 checks passed
Kietyo added a commit to Kietyo/korge-kietyo that referenced this pull request Aug 10, 2023
Kietyo added a commit that referenced this pull request Aug 11, 2023
* Refactor out part of the sandbox code so it can be used for Jvm entrypoint.

* Update entrypoint name.

* Fix grayscale jpeg rendering.

* Remove unused code (#1825)

* remove commented code

* remove unused code

* remove unused code

* remove unused code

---------

Co-authored-by: Alexandre Mommers <[email protected]>

* Convert buildSrc to using kts (#1830)

* Delete build.gradle.old (#1831)

* enable tests on release branches (#1833)

* Fix grayscale jpeg rendering.

* Try fix test-native-macos.

* Try fix test-native-macos. pt.2

---------

Co-authored-by: Alexandre Mommers <[email protected]>
Co-authored-by: Alexandre Mommers <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants