-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove unused code #1825
remove unused code #1825
Conversation
We should be very careful about this. |
Of course so far, i only removed old implementation and commented code. Do you want to do a review if test are ok ? |
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #1825 +/- ##
==========================================
- Coverage 51.10% 51.10% -0.01%
==========================================
Files 1750 1749 -1
Lines 102836 102833 -3
Branches 14520 14519 -1
==========================================
- Hits 52559 52553 -6
+ Misses 46346 46344 -2
- Partials 3931 3936 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
LGTM |
* remove commented code * remove unused code * remove unused code * remove unused code --------- Co-authored-by: Alexandre Mommers <[email protected]>
* Refactor out part of the sandbox code so it can be used for Jvm entrypoint. * Update entrypoint name. * Fix grayscale jpeg rendering. * Remove unused code (#1825) * remove commented code * remove unused code * remove unused code * remove unused code --------- Co-authored-by: Alexandre Mommers <[email protected]> * Convert buildSrc to using kts (#1830) * Delete build.gradle.old (#1831) * enable tests on release branches (#1833) * Fix grayscale jpeg rendering. * Try fix test-native-macos. * Try fix test-native-macos. pt.2 --------- Co-authored-by: Alexandre Mommers <[email protected]> Co-authored-by: Alexandre Mommers <[email protected]>
No description provided.