Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused code #1825

Merged
merged 5 commits into from
Aug 9, 2023
Merged

remove unused code #1825

merged 5 commits into from
Aug 9, 2023

Conversation

ygdrasil-io
Copy link
Member

No description provided.

@ygdrasil-io ygdrasil-io changed the title remove commented code remove unused code Aug 7, 2023
@Kietyo
Copy link
Contributor

Kietyo commented Aug 7, 2023

We should be very careful about this.
Much of the "unused" code are code for clients to use so they will only appear unused from our perspective.
The multiplatform code is especially impacted by this and the infra may actually need that code for the multiplatform builds.

@ygdrasil-io
Copy link
Member Author

We should be very careful about this. Much of the "unused" code are code for clients to use so they will only appear unused from our perspective. The multiplatform code is especially impacted by this and the infra may actually need that code for the multiplatform builds.

Of course so far, i only removed old implementation and commented code. Do you want to do a review if test are ok ?

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 66.66% and project coverage change: -0.01% ⚠️

Comparison is base (7336e7e) 51.10% compared to head (20f3b65) 51.10%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1825      +/-   ##
==========================================
- Coverage   51.10%   51.10%   -0.01%     
==========================================
  Files        1750     1749       -1     
  Lines      102836   102833       -3     
  Branches    14520    14519       -1     
==========================================
- Hits        52559    52553       -6     
+ Misses      46346    46344       -2     
- Partials     3931     3936       +5     
Flag Coverage Δ
unittests 51.10% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...Main/kotlin/korlibs/render/DefaultGameWindowJvm.kt 0.00% <ø> (ø)
...in/kotlin/korlibs/render/platform/PlatformTools.kt 0.00% <ø> (ø)
...Main/kotlin/korlibs/render/x11/X11GameWindowJvm.kt 0.00% <0.00%> (ø)
...dMain/kotlin/korlibs/inject/AsyncInjectorJvmExt.kt 39.28% <100.00%> (-0.37%) ⬇️

... and 21 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kietyo
Copy link
Contributor

Kietyo commented Aug 8, 2023

LGTM

@ygdrasil-io ygdrasil-io marked this pull request as ready for review August 8, 2023 11:51
@Kietyo Kietyo merged commit fe03913 into korlibs:main Aug 9, 2023
9 checks passed
@ygdrasil-io ygdrasil-io deleted the fix/code-cleanup branch August 9, 2023 10:44
Kietyo pushed a commit to Kietyo/korge-kietyo that referenced this pull request Aug 10, 2023
* remove commented code

* remove unused code

* remove unused code

* remove unused code

---------

Co-authored-by: Alexandre Mommers <[email protected]>
Kietyo added a commit that referenced this pull request Aug 11, 2023
* Refactor out part of the sandbox code so it can be used for Jvm entrypoint.

* Update entrypoint name.

* Fix grayscale jpeg rendering.

* Remove unused code (#1825)

* remove commented code

* remove unused code

* remove unused code

* remove unused code

---------

Co-authored-by: Alexandre Mommers <[email protected]>

* Convert buildSrc to using kts (#1830)

* Delete build.gradle.old (#1831)

* enable tests on release branches (#1833)

* Fix grayscale jpeg rendering.

* Try fix test-native-macos.

* Try fix test-native-macos. pt.2

---------

Co-authored-by: Alexandre Mommers <[email protected]>
Co-authored-by: Alexandre Mommers <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants