Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/hungry-islands-accept.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@kopai/sqlite-datasource": minor
"@kopai/core": minor
---

Extended support for attribute values to include arrays of strings, numbers, and booleans alongside primitive values, broadening the allowed data types for OpenTelemetry resource and span attributes.
9 changes: 8 additions & 1 deletion packages/core/src/denormalized-signals-zod.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
import { z } from "zod";

const attributeValue = z.union([z.string(), z.number(), z.boolean()]);
const attributeValue = z.union([
z.string(),
z.number(),
z.boolean(),
z.array(z.string()),
z.array(z.number()),
z.array(z.boolean()),
]);

export const otelTracesSchema = z.object({
// Required fields
Expand Down
62 changes: 61 additions & 1 deletion packages/sqlite-datasource/src/datasource-read.test.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/// <reference types="vitest/globals" />
import { DatabaseSync } from "node:sqlite";
import { NodeSqliteTelemetryDatasource } from "./datasource.js";
import { otlp, type datasource } from "@kopai/core";
import { otlp, denormalizedSignals, type datasource } from "@kopai/core";
import { initializeDatabase } from "./initialize-database.js";
import { SqliteDatasourceQueryError } from "./sqlite-datasource-error.js";

Expand Down Expand Up @@ -515,6 +515,66 @@ describe("NodeSqliteTelemetryDatasource", () => {
});
});

it("returns array attribute values in ResourceAttributes", async () => {
// OTel attributes can be arrays (e.g. process.command_args)
await ds.writeTraces({
resourceSpans: [
{
resource: {
attributes: [
{
key: "process.command_args",
value: {
arrayValue: {
values: [
{ stringValue: "node" },
{ stringValue: "server.js" },
{ stringValue: "--port=3000" },
],
},
},
},
{
key: "service.name",
value: { stringValue: "test-service" },
},
],
},
scopeSpans: [
{
scope: { name: "test-scope" },
spans: [
{
traceId: "trace-with-array-attr",
spanId: "span1",
name: "test-span",
startTimeUnixNano: "1000000000000000",
endTimeUnixNano: "1001000000000000",
},
],
},
],
},
],
});

const result = await readDs.getTraces({
traceId: "trace-with-array-attr",
});

expect(result.data).toHaveLength(1);
const row = result.data[0];
assertDefined(row);
expect(row.ResourceAttributes).toEqual({
"process.command_args": ["node", "server.js", "--port=3000"],
"service.name": "test-service",
});

// Validate schema accepts array attribute values (this is what fastify validates)
const parseResult = denormalizedSignals.otelTracesSchema.safeParse(row);
expect(parseResult.success).toBe(true);
});

it("parses Events and Links fields as arrays", async () => {
await insertSpan({
traceId: "trace-with-events-links",
Expand Down