Skip to content

fix(core,sqlite,app): attribute value schema#22

Merged
Vunovati merged 2 commits into
mainfrom
fix/attributes-value-array
Jan 27, 2026
Merged

fix(core,sqlite,app): attribute value schema#22
Vunovati merged 2 commits into
mainfrom
fix/attributes-value-array

Conversation

@Vunovati
Copy link
Copy Markdown
Collaborator

@Vunovati Vunovati commented Jan 27, 2026

Summary by CodeRabbit

  • New Features

    • Extended support for attribute values to include arrays of strings, numbers, and booleans alongside primitive values, broadening allowed data types for OpenTelemetry resource, span, metric, and exemplar attributes.
  • Tests

    • Added test coverage to verify array-type attribute values are correctly preserved when writing and reading traces.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jan 27, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The OTEL denormalized schema now accepts array attribute values (string[], number[], boolean[]) in addition to primitives; a test was added verifying array values in ResourceAttributes persist through the sqlite datasource read path.

Changes

Cohort / File(s) Summary
Schema Extension
packages/core/src/denormalized-signals-zod.ts
Expanded the attributeValue union to include string[], number[], and boolean[], affecting ResourceAttributes, SpanAttributes, exemplars, metrics attributes, etc.
Test Coverage
packages/sqlite-datasource/src/datasource-read.test.ts
Added denormalizedSignals import and a new test that writes a trace with an array attribute (e.g., process.command_args), reads it back, asserts the array is preserved, and validates against the extended schema.
Changelog / Release
.changeset/hungry-islands-accept.md
Version bumps and changelog entry describing added array support for OTEL attribute values.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 I found some arrays beneath the log tree,
Hopping through attributes, wild and free,
Primitives joined by lists in a row,
Tests gave them wings, so onward they go! 🥕✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix(core,sqlite,app): attribute value schema' directly describes the main change—expanding the attribute value schema to support arrays across core, sqlite, and app packages.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@Vunovati Vunovati merged commit 03ebb7d into main Jan 27, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant